changeset: add required changeKind field to Changeset#194
Merged
lszomoru merged 3 commits intoJun 4, 2026
Merged
Conversation
Adds a required `changeKind: string` advisory hint to the `Changeset` catalogue entry so clients can group, sort, or pick an icon without parsing `uriTemplate`. Follows the same open-vocabulary pattern as `MessageAttachmentBase.displayKind`. Recognized values: `session`, `branch`, `uncommitted`, `turn`, `turn-compare`. Implementations MAY provide additional values; clients SHOULD fall back to a reasonable default when an unknown value is encountered. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The new required `changeKind` field on `Changeset` caused the Go and Rust fixture-driven reducer tests to fail because their round-trip serialisation expected every Changeset to carry a `changeKind`. Update fixtures 145 and 146 to set `changeKind: 'session'`. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use `compare-turns` consistently in the well-known `changeKind` value list documented on `Changeset`. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
connor4312
approved these changes
Jun 4, 2026
lszomoru
deleted the
agents/let-s-add-changekind-string-to-the-changeset-4f6b8dbc
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a required
changeKind: stringadvisory hint to theChangesetcatalogue entry on theahp-changeset:channel.Why
Clients (UI hosts) want to group, sort, or pick an icon for a changeset without parsing the RFC 6570
uriTemplate.changeKindmakes the intent explicit and follows the same open-vocabulary pattern already established byMessageAttachmentBase.displayKind.Recognized values
session— a static, session-wide changeset covering all changes the agent has produced in this sessionbranch— changes relative to a base branch (e.g. a feature branch diffed againstmain)uncommitted— the workspace's current uncommitted changesturn— changes produced by a single turn (typically paired with{turnId})turn-compare— diff between two turns (typically paired with{originalTurnId}and{modifiedTurnId})Implementations MAY provide additional values; clients SHOULD fall back to a reasonable default when an unknown value is encountered.
Notes for reviewers
Changesetentries.npm run generate.## [Unreleased].npm run typecheck,npm run lint, andnpm run test(235 tests) all pass.