feat: auto-compose the public wayfinder channel on every session - #277
Merged
Conversation
Adds _build_wayfinder_behaviors() and wires it into resolve_bundle_config() alongside the existing modes / skills / cli-expertise Tier-A defaults, so the PUBLIC wayfinder in-session guidance channel ships to every user by default. Previously wayfinder only reached users who had the internal made-support bundle in their bundle.app settings. Now every session composes: git+https://github.com/microsoft/amplifier-bundle-wayfinder@main#subdirectory=behaviors/wayfinder.yaml No internal content leaks: only the PUBLIC behavior is composed here. Internal content packs (e.g. amplifier-online) ride separately via made-support's own hooks-wayfinder content_sources config, which composes AFTER app bundles and deep-merges its extra content source onto the hook. Composing wayfinder twice (app default + made-support) is idempotent — foundation merges modules by id. Validated in a Digital Twin Universe representing a made-support-free public user (no bundle.app): 'Hi' auto-surfaces a wayfinder offer, the full menu renders, and amplifier-online is absent from the public menu (0 matches). 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes the public wayfinder in-session guidance channel a shipped default for every Amplifier CLI user — not just those who have the internal
made-supportbundle in theirbundle.appsettings.Adds
_build_wayfinder_behaviors()and wires it intoresolve_bundle_config()alongside the existingmodes/skills/cli-expertiseTier-A defaults, so every session composes:Why
Wayfinder surfaces one authored, curated tip per session and offers capabilities the user already has, always behind an explicit propose → show → ack → act gate. It previously only reached users who had added the internal
made-supportapp bundle. This makes the public channel reach everyone by default, matching howmodesandskillsalready ship.No internal content leaks
Only the PUBLIC behavior is composed here. Internal/team content packs (e.g.
amplifier-online) are not included — they ride separately throughmade-support's ownhooks-wayfindercontent_sourcesconfig, which composes after app bundles and deep-merges its extra content source onto the hook. Composing wayfinder twice (this app default +made-support) is idempotent: foundation merges modules by id, so the internalcontent_sources.madestill layers on top for internal users, and nothing internal appears for public users.Validation
Verified in a Digital Twin Universe representing a made-support-free public user (no
bundle.app), with the CLI built from this branch's source:amplifier run "Hi"auto-surfaces a wayfinder offer with no config.amplifier-onlineis absent from the public menu (0 matches).pyrightclean on the modified file.🤖 Generated with Amplifier
Co-Authored-By: Amplifier 240397093+microsoft-amplifier@users.noreply.github.com