Skip to content

Add compatibility suppressions for NameOutput rename in Azure.Network#16022

Merged
eerhardt merged 1 commit intomicrosoft:mainfrom
eerhardt:FixBuildBreak
Apr 10, 2026
Merged

Add compatibility suppressions for NameOutput rename in Azure.Network#16022
eerhardt merged 1 commit intomicrosoft:mainfrom
eerhardt:FixBuildBreak

Conversation

@eerhardt
Copy link
Copy Markdown
Member

@eerhardt eerhardt commented Apr 10, 2026

Description

Add CompatibilitySuppressions.xml for Aspire.Hosting.Azure.Network to suppress CP0002 package validation diagnostics caused by the NameOutputNameOutputReference rename in #16004, after the baseline version was bumped in #16008.

The following resources have suppressions for the removed NameOutput getter:

  • AzureNatGatewayResource
  • AzureNetworkSecurityGroupResource
  • AzurePrivateEndpointResource
  • AzurePublicIPAddressResource
  • AzureVirtualNetworkResource

This is acceptable because this library is still Experimental.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

The NameOutput property was renamed to NameOutputReference in microsoft#16004,
and the baseline version was bumped in microsoft#16008. Add CP0002 suppressions
for the removed NameOutput getters on the 5 affected network resources.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 10, 2026 01:22
@github-actions
Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16022

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16022"

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a package validation suppression file for Aspire.Hosting.Azure.Network to silence CP0002 compatibility diagnostics triggered by the earlier NameOutputNameOutputReference rename after the baseline version bump.

Changes:

  • Introduces CompatibilitySuppressions.xml in Aspire.Hosting.Azure.Network.
  • Suppresses CP0002 for the removed get_NameOutput accessor on the affected public resource types.

@eerhardt eerhardt merged commit ff28eba into microsoft:main Apr 10, 2026
526 of 532 checks passed
@eerhardt eerhardt deleted the FixBuildBreak branch April 10, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants