Skip to content

Update Tuf and Sigstore to 1.0.1 - #19595

Draft
Mitch Denny (mitchdenny) wants to merge 2 commits into
mainfrom
mitchdenny-test-tuf-sigstore-packages
Draft

Update Tuf and Sigstore to 1.0.1#19595
Mitch Denny (mitchdenny) wants to merge 2 commits into
mainfrom
mitchdenny-test-tuf-sigstore-packages

Conversation

@mitchdenny

@mitchdenny Mitch Denny (mitchdenny) commented Aug 22, 2026

Copy link
Copy Markdown
Member

Description

Updates the Aspire CLI's Sigstore and Tuf dependencies from 1.0.0 to stable 1.0.1.

The stable packages are restored directly from nuget.org using exact package source mappings because the normal upstream feed does not contain them yet. The mapping limits the public source to the Sigstore and Tuf package IDs.

Validation:

  • Built a Linux ARM64 local-hive archive containing stable Sigstore and Tuf 1.0.1.
  • Ran NewWithAgentInitTests and PlaywrightCliInstallTests against that archive: 3 passed.
  • Set NuGetAudit=false for the targeted build because enabling nuget.org surfaces unrelated, pre-existing transitive package advisories as warnings-as-errors.

Security considerations

This draft restores two security-sensitive dependencies directly from nuget.org. Package source mapping restricts the public source to the exact Sigstore and Tuf package IDs. The nuget.org override remains necessary until the normal upstream feed mirrors 1.0.1.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 22, 2026 04:34
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19595

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19595"

@github-actions github-actions Bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 22, 2026
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Aspire CLI provenance dependencies to a preview build.

Changes:

  • Updates Sigstore and Tuf to 1.0.1-beta.122.1.7bc133a.
  • Temporarily adds nuget.org package resolution for those packages.
Show a summary per file
File Description
NuGet.config Adds nuget.org source and mappings.
Directory.Packages.props Updates Sigstore and Tuf versions.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread NuGet.config
<!-- Begin: Package sources from dotnet-runtime -->
<!-- End: Package sources from dotnet-runtime -->
<!--End: Package sources managed by Dependency Flow automation. Do not edit the sources above.-->
<add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: abe48954-d882-4cd8-9eb9-a452ea20c5d2
Copilot AI review requested due to automatic review settings August 24, 2026 01:41
@mitchdenny Mitch Denny (mitchdenny) changed the title Update Tuf and Sigstore to 1.0.1 beta Update Tuf and Sigstore to 1.0.1 Aug 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Tests selector (audit mode)

The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement.

Runs the full test matrix + all jobs (ALL) — a rule matching 'Directory.Packages.props' selects ALL


Selection computed for commit 034173d.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Suppressed comments (1)

NuGet.config:17

  • This permanently adds an unapproved public feed to the repository configuration. Aspire's internal build cannot restore external dependencies directly from nuget.org; these versions must first be mirrored through the dependency migration pipeline and consumed from an approved dnceng feed. Please mirror Sigstore and Tuf, then remove the nuget.org source, its source mapping, and the related disabledPackageSources override.
    <add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants