Update Tuf and Sigstore to 1.0.1 - #19595
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19595Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19595" |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Updates Aspire CLI provenance dependencies to a preview build.
Changes:
- Updates
SigstoreandTufto1.0.1-beta.122.1.7bc133a. - Temporarily adds nuget.org package resolution for those packages.
Show a summary per file
| File | Description |
|---|---|
NuGet.config |
Adds nuget.org source and mappings. |
Directory.Packages.props |
Updates Sigstore and Tuf versions. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
| <!-- Begin: Package sources from dotnet-runtime --> | ||
| <!-- End: Package sources from dotnet-runtime --> | ||
| <!--End: Package sources managed by Dependency Flow automation. Do not edit the sources above.--> | ||
| <add key="nuget.org" value="https://api.nuget.org/v3/index.json" /> |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: abe48954-d882-4cd8-9eb9-a452ea20c5d2
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. Runs the full test matrix + all jobs (ALL) — a rule matching 'Directory.Packages.props' selects ALL Selection computed for commit |
There was a problem hiding this comment.
Review details
Suppressed comments (1)
NuGet.config:17
- This permanently adds an unapproved public feed to the repository configuration. Aspire's internal build cannot restore external dependencies directly from nuget.org; these versions must first be mirrored through the dependency migration pipeline and consumed from an approved dnceng feed. Please mirror
SigstoreandTuf, then remove the nuget.org source, its source mapping, and the relateddisabledPackageSourcesoverride.
<add key="nuget.org" value="https://api.nuget.org/v3/index.json" />
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Balanced
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
Description
Updates the Aspire CLI's
SigstoreandTufdependencies from1.0.0to stable1.0.1.The stable packages are restored directly from nuget.org using exact package source mappings because the normal upstream feed does not contain them yet. The mapping limits the public source to the
SigstoreandTufpackage IDs.Validation:
SigstoreandTuf1.0.1.NewWithAgentInitTestsandPlaywrightCliInstallTestsagainst that archive: 3 passed.NuGetAudit=falsefor the targeted build because enabling nuget.org surfaces unrelated, pre-existing transitive package advisories as warnings-as-errors.Security considerations
This draft restores two security-sensitive dependencies directly from nuget.org. Package source mapping restricts the public source to the exact
SigstoreandTufpackage IDs. The nuget.org override remains necessary until the normal upstream feed mirrors1.0.1.Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?