Fix: Handle nested objects in array items for JSON schema conversion - #6993
Merged
Eric Zhu (ekzhu) merged 4 commits intoSep 18, 2025
Merged
Conversation
- Modified _extract_field_type to recursively process object schemas in arrays - Added test case for array items with defined object properties - Fixes issue microsoft#6991
kkutrowski
marked this pull request as draft
September 5, 2025 11:07
kkutrowski
marked this pull request as ready for review
September 5, 2025 11:11
Contributor
Author
|
@microsoft-github-policy-service agree company="PFEIFER & LANGEN BUSINESS SOLUTIONS" |
Eric Zhu (ekzhu)
approved these changes
Sep 16, 2025
Eric Zhu (ekzhu)
left a comment
Contributor
There was a problem hiding this comment.
Generally speaking, it is a good idea to avoid using complex data types for tool arguments. They tend to degrade model performance. While the fix here is valid, we don't recommend passing in complex data types for tools.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6993 +/- ##
=======================================
Coverage 80.95% 80.96%
=======================================
Files 238 238
Lines 18271 18279 +8
=======================================
+ Hits 14791 14799 +8
Misses 3480 3480
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The changes are needed so the agents can see entire tools input schema properly.
Related issue number
Closes #6991
Checks