fix(file-surfer): preserve base path in components - #8100
Open
YZJF,YCDG,DJLY,ZZZB (YZJF) wants to merge 1 commit into
Open
fix(file-surfer): preserve base path in components#8100YZJF,YCDG,DJLY,ZZZB (YZJF) wants to merge 1 commit into
YZJF,YCDG,DJLY,ZZZB (YZJF) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
FileSurferaccepts an explicitbase_path, but its component configuration did not store that value. Reconstructing a serialized component therefore created a browser rooted at the process default instead of its originally configured directory. This loses the caller's intended filesystem scope in persisted teams and Studio configurations.This change persists the browser's resolved base path in
FileSurferConfigand restores it when loading the component. Configurations written before this field existed continue to use the legacy constructor behavior.Related issue number
None.
Checks
base_pathdocumentation remains accurate.uv run --directory python --no-sync pytest packages/autogen-ext/tests/test_filesurfer_agent.py -vvuv run --directory python --no-sync ruff check packages/autogen-ext/src/autogen_ext/agents/file_surfer/_file_surfer.py packages/autogen-ext/tests/test_filesurfer_agent.pyuv run --directory python --no-sync ruff format --check packages/autogen-ext/src/autogen_ext/agents/file_surfer/_file_surfer.py packages/autogen-ext/tests/test_filesurfer_agent.pyuv run --directory python --no-sync pyright packages/autogen-ext/src/autogen_ext/agents/file_surfer/_file_surfer.py packages/autogen-ext/tests/test_filesurfer_agent.pyAI assistance
AI assistance was used to investigate, draft, and test this change. The regression was reproduced before the implementation: serializing a
FileSurferwith an explicit temporary directory reloaded it with the process working directory instead.