Add async context manager to OpenAI model client - #8103
Open
mikemikimike wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenAIChatCompletionClientalready exposes an asynchronousclose()method, but callers cannot use the client withasync with. This change adds the async context manager protocol to the shared OpenAI client base so OpenAI-compatible clients return themselves on entry and close their underlying client on exit.Testing
ruff format --checkon the changed source and test filesruff checkon the changed source and test filespytest python/packages/autogen-ext/tests/models/test_openai_model_client.py -k async_context_manager --no-covCloses #5108.