[dev-v5] Update project files for .NET 8 support#4953
Draft
dvoituron wants to merge 1 commit into
Draft
Conversation
…ies for .NET 8 support
Contributor
There was a problem hiding this comment.
Pull request overview
Updates repository-wide .NET targeting to improve .NET 8 support for published libraries while keeping demos/samples/tests on a newer “example” TFM, and adjusts a component to use the GeneratedRegex source-generator pattern.
Changes:
- Split framework selection into
NetVersion(libraries) vsExampleNetVersion(demos/samples/tests) and updated many project files accordingly. - Added net8-specific central package versions in
Directory.Packages.props. - Updated
FluentColorPickerInputto useGeneratedRegexwith a partial method (HexColorRegex()).
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Tools/McpServer.Tests/Microsoft.FluentUI.AspNetCore.McpServer.Tests.csproj | Switch test project TFM to $(ExampleNetVersion). |
| tests/Integration/Components.IntegrationTests.csproj | Switch integration test TFM to $(ExampleNetVersion). |
| tests/Core/Components.Tests.csproj | Switch unit test TFM to $(ExampleNetVersion). |
| src/Core/Components/ColorPicker/FluentColorPickerInput.razor.cs | Update regex generator usage to GeneratedRegex partial method pattern. |
| examples/Tools/FluentUI.Demo.SampleData/FluentUI.Demo.SampleData.csproj | Switch tool project TFM to $(ExampleNetVersion). |
| examples/Tools/FluentUI.Demo.SampleApi/FluentUI.Demo.SampleApi.csproj | Switch tool project TFM to $(ExampleNetVersion). |
| examples/Tools/FluentUI.Demo.DocViewer/FluentUI.Demo.DocViewer.csproj | Switch tool project TFM to $(ExampleNetVersion). |
| examples/Tools/FluentUI.Demo.DocViewer.Tests/FluentUI.Demo.DocViewer.Tests.csproj | Switch tool test project TFM to $(ExampleNetVersion). |
| examples/Tools/FluentUI.Demo.DocApiGen/FluentUI.Demo.DocApiGen.csproj | Switch doc generator TFM to $(ExampleNetVersion). |
| examples/Tools/FluentUI.Demo.DocApiGen.Tests/FluentUI.Demo.DocApiGen.Tests.csproj | Switch doc generator tests TFM to $(ExampleNetVersion). |
| examples/Tools/FluentUI.Demo.DocApiGen.IntegrationTests/FluentUI.Demo.DocApiGen.IntegrationTests.csproj | Switch doc generator integration tests TFM to $(ExampleNetVersion). |
| examples/Samples/FluentUI.Samples.WasmStandalone/FluentUI.Samples.WasmStandalone.csproj | Switch sample app TFM to $(ExampleNetVersion). |
| examples/Demo/FluentUI.Explorers/FluentUI.Explorers.csproj | Switch demo explorer TFM to $(ExampleNetVersion). |
| examples/Demo/FluentUI.Demo/FluentUI.Demo.csproj | Switch demo host TFM to $(ExampleNetVersion). |
| examples/Demo/FluentUI.Demo.Client/FluentUI.Demo.Client.csproj | Switch client TFM and related conditions to $(ExampleNetVersion). |
| Directory.Packages.props | Introduce net8-specific package version set and version properties. |
| Directory.Build.props | Define NetVersion vs ExampleNetVersion and adjust multi-targeting configuration. |
| <!-- Used with the published libraries: Core; McpServer; Charts; DataGrid adapters --> | ||
| <!-- Debug: minimum + ExampleNetVersion for faster builds; Release: full multi-targeting --> | ||
| <TargetNetVersions Condition="'$(Configuration)' == 'Release'">net8.0;net9.0;net10.0</TargetNetVersions> | ||
| <TargetNetVersions Condition="'$(Configuration)' != 'Release'">$(NetVersion)</TargetNetVersions> |
Comment on lines
+4
to
+6
| <RuntimeVersion8>8.0.0</RuntimeVersion8> | ||
| <AspNetCoreVersion8>8.0.22</AspNetCoreVersion8> | ||
| <EfCoreVersion8>8.0.0</EfCoreVersion8> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[dev-v5] Update project files for .NET 8 support
Adjust project files to target the appropriate .NET versions and update dependencies for compatibility with .NET 8.
This change enhances support for newer frameworks and ensures proper functionality across projects.