Conversation
Co-authored-by: dagood <12819531+dagood@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Convert all CRLF line endings to LF
Convert all CRLF to LF
Feb 26, 2026
Member
|
@copilot it's important that msGo.output.manifest.json keep UTF-16 LE CRLF sequences. This is what this program has to parse in the wild, so it's important to test it. Revert these files to their old state and add a Also, add a check to |
…butes and format check Co-authored-by: dagood <12819531+dagood@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/go-infra/sessions/b36ba2ad-18c0-4823-acb2-7811d233e85c
Contributor
Author
Done in fc7378d:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several text files in the repo contained CRLF line endings, inconsistent with the LF-only policy enforced via
.gitattributes.Changes
\rfromSUPPORT.mdand.azuredevops/dependabot.ymlbuildmodel/publishmanifest/testdata/msGo.output.manifest.json; this required binary-level patching sincesedonly handles byte-oriented encodingsbuildmodel/buildassetsmanifest testdata preserved as-is —buildmodel/buildassets/testdata/*/msGo.output.manifest.jsonfiles are kept in their original UTF-16 LE CRLF format because they represent real-world pipeline output that the parser must handle in productionpatch/testdata/moremath.pack(git bundle) contain legitimate\rbytes and are not text filesSafeguards for
buildmodel/buildassetstestdatabuildmodel/buildassets/testdata/.gitattributesmarking*/msGo.output.manifest.jsonas-text(binary) so git will never normalize their line endingscheckManifestIsUTF16LECRLFcheck insideTestBuildResultsDirectoryInfo_GoldenCreateSummarythat fails with a clear message if the UTF-16 LE BOM or CRLF sequences are ever stripped from these files✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.