Fix/6836 query parameters default value#6845
Fix/6836 query parameters default value#6845martin-machacek-tfs wants to merge 5 commits intomicrosoft:mainfrom
Conversation
…de the default value
…de the default value
@microsoft-github-policy-service agree company="thermofisher" |
baywet
left a comment
There was a problem hiding this comment.
Thanks for the contribution! This is a great start!
This is usually the kind of thing we drive across all stable languages to have parity, do you feel like giving a try to other languages?
…de the default value
|
@baywet Just to clarify how to properly set the default value for other languages:
It's a bit out of my scope, but I can try |
…de the default value
|
Hi @baywet, I've extended CodePropertyWriter for Java, PHP and Python to generate default values. Default values for Go are already generated via constructor function. |
baywet
left a comment
There was a problem hiding this comment.
Thank you for making the changes!
Thank you for your patience.
Just one minor comment for the changelog and I think we'll be good to go!
|
@martin-machacek-tfs it seems some integration tests are failing, would you please mind having a look? |
@baywet Is there any way to run those integration tests locally? At first glance I have no idea what could be wrong. At least I would expect the existing unit tests to reveal those kind of errors. |
…de the default value
|
@martin-machacek-tfs yes! If you check the generate code step, it'll tell you which command it used to generate the code https://github.com/microsoft/kiota/actions/runs/17066554507/job/49093389068#step:16:2 Simply build kiota before handle (dotnet build) and add a Once the code is generated, the test step will tell you which command it ran to execute the test. https://github.com/microsoft/kiota/actions/runs/17066554507/job/49093389068#step:17:8 Let me know if you have any additional comments or questions. |
Closes #6836