Open
Conversation
baywet
requested changes
Mar 4, 2026
Member
baywet
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
I double checked and the other big consumer of this package is also using a bundler
https://github.com/OfficeDev/microsoft-365-agents-toolkit/blob/c0eb0bed661202bfd85b3bb1bd61e21b0b73c0b4/packages/fx-core/package.json#L87
Contributor
Author
|
@baywet I left two points unresolved. Also could you please trigger CI? |
Member
done. Another aspect of cjs I forgot to mention earlier is jest's configuration that'll need to be updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@baywet Getting clean ESM + CommonJS outputs without introducing bundling has been messy, so I went with this approach:
lib/foldertsconfig.jsonto includelib/instead of excluding everything elseThe VSCode plugin should still work fine with ESM because it’s bundled with webpack, so webpack will bundle what it needs from the ESM module and tree-shake unused exports where possible.