ci: suppress the typescript idempotency test for the github description - #8106
Closed
om singhal (Om-singhaI) wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for opening this pull request! Please add a changelog entry under |
Member
|
Thanks for the contribution! I had copilot put together a fix in #8107 Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The typescript idempotency test against the github description started failing for every pull request once the description was refreshed. It is the generation crash from #7803, which is still open:
error generating the client: Function deserializeIntoWithPath not found in namespace ApiSdk.models. I reproduced it on main at d5f667d with no other changes, so it is the description plus the generator, not any one branch.Integration is already suppressed for typescript on this description, but idempotency is not, so it blocks the merge queue and every open pull request. This adds the matching
IdempotencySuppressionsentry pointing at #7803, the same shape the notion description uses for its sibling issue. Generation for typescript cannot be idempotent while it crashes, so nothing is lost by skipping it until #7803 is fixed.Related: #7803