Add ip service tags update hook#4565
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an Azure pluggy hook to allow extending/overriding Public IP service tags during ARM deployment parameter creation, enabling subscription-specific customization without modifying core deployment logic.
Changes:
- Adds a new Azure hookspec
azure_update_ip_service_tagintended to let plugins update Public IP service tags before deployment. - Invokes the new hook during Azure ARM deployment parameter construction, with a fallback to the existing BYOIP default tag when no tags are set.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lisa/sut_orchestrator/azure/platform_.py | Calls the new hook while constructing ARM deployment parameters (Public IP service tags). |
| lisa/sut_orchestrator/azure/hooks.py | Defines the new Azure hookspec for updating IP service tags. |
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
lubaihua33
force-pushed
the
baihua/tag_hook
branch
from
4a6c800 to
3ca7a9c
Compare
✅ AI Test Selection — PASSED1 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
LiliDeng
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add IP service tags update hook
Type of Change
Checklist
Test Validation
Have run some tests for ip_service_tags. They are all passed.
Test Results