Open
Conversation
conniey
requested review from
JonathanCrd,
alzimmermsft,
Copilot,
msalaman,
saikoumudi,
sandeep-sen,
tmeschter and
xiangyan99
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s devcontainer configuration to reference a valid, non-preview .NET 10 devcontainer image (addressing the broken image reference reported in #1407).
Changes:
- Switch
.devcontainer/devcontainer.jsonimage fromdev-10.0-previewtodev-10.0. - Pin the PowerShell devcontainer feature to
ghcr.io/devcontainers/features/powershell:2.0.1.
jongio
approved these changes
Apr 7, 2026
| }, | ||
| "ghcr.io/devcontainers/features/azure-cli:1": {}, | ||
| "ghcr.io/devcontainers/features/powershell:1": {}, | ||
| "ghcr.io/devcontainers/features/powershell:2.0.1": {}, |
Contributor
There was a problem hiding this comment.
Every other feature in this file uses a major-version-only constraint (node:1, azure-cli:1, docker-in-docker:2, azd:0), and the feature's docs recommend powershell:2. Pinning to 2.0.1 prevents automatic patch/minor updates and breaks the pattern. Consider:
Suggested change
| "ghcr.io/devcontainers/features/powershell:2.0.1": {}, | |
| "ghcr.io/devcontainers/features/powershell:2": {}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1407 . Updates dev container image.
GitHub issue number?
Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline