Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves MCP registry publishing of server.json from a custom Go-based deploy script to an ESRP-based release flow in the Azure Pipelines release job, removing the Go install/build/deploy scripts from the repo.
Changes:
- Removed the PowerShell scripts that installed Go and built/ran the MCP registry publisher tool.
- Updated the release pipeline to use a dedicated
mcp-registry/release-server-json.ymljob template. - Updated the MCP registry release job to stage
server.json, publish it as a pipeline artifact, and release it viaESRPRelease@10.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/scripts/Install-Go.ps1 | Deleted; no longer needed after removing Go-based publisher flow. |
| eng/scripts/Deploy-ServerJson.ps1 | Deleted; replaced by ESRP-based release mechanism. |
| eng/pipelines/templates/jobs/release.yml | Switched from the prior update job template to the new MCP registry release job template. |
| eng/pipelines/templates/jobs/mcp-registry/release-server-json.yml | Stages server.json, publishes artifact, and uses ESRPRelease@10 to publish to the MCP registry. |
Comments suppressed due to low confidence (3)
eng/pipelines/templates/jobs/mcp-registry/release-server-json.yml:66
- The staging step copies server.json into the root of
$(Build.ArtifactStagingDirectory) and ESRPRelease later publishes the entire folder. If any other files land in that directory in this job (now or in future edits), they could be unintentionally released to the MCP registry. Stage into a dedicated subfolder (e.g., $ (Build.ArtifactStagingDirectory)/serverjson) and point both the artifact publish and ESRP FolderLocation at that subfolder to ensure only server.json is released.
eng/pipelines/templates/jobs/mcp-registry/release-server-json.yml:60 - This logs the full contents of server.json to the build output. That can be very noisy, and if server.json ever contains more than public metadata (e.g., internal endpoints), it would be exposed in pipeline logs. Consider removing the dump or replacing it with a lightweight validation (e.g., file exists + JSON parse) and/or logging only the path and a few key fields.
eng/pipelines/templates/jobs/mcp-registry/release-server-json.yml:76 - The ESRPRelease task displayName still references publishing native platform packages to npmjs.com, which doesn’t match what this step does (publishes server.json to the MCP registry). Updating the displayName will make pipeline runs easier to understand and troubleshoot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Instead of building and running the server.json deploy tool, use the ESRP release task to update the central mcp registry
Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline