Add lightweight styling resources for AppBarButton width - #11590
Closed
Niels Laute (niels9001) wants to merge 1 commit into
Closed
Add lightweight styling resources for AppBarButton width#11590Niels Laute (niels9001) wants to merge 1 commit into
Niels Laute (niels9001) wants to merge 1 commit into
Conversation
Add overridable width resources for AppBarButton and AppBarToggleButton while preserving auto-sized overflow and local Width precedence. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8ab4ed7c-df52-4775-bc59-85ca7fbd5ec4
microsoft-github-policy-service
Bot
added
the
needs-triage
| <Setter Property="FontFamily" Value="{ThemeResource ContentControlThemeFontFamily}" /> | ||
| <Setter Property="FontWeight" Value="Normal" /> | ||
| <Setter Property="Width" Value="68" /> | ||
| <Setter Property="Width" Value="{ThemeResource AppBarButtonWidth}" /> |
Contributor
There was a problem hiding this comment.
AppBarButtonWidth isn't a theme resource. Should this be StaticResource ? Comparing to for instance AppBarButtonInnerBorderOverflowMargin above it, that's always referenced as a static resource. Same goes for the other changes.
13 tasks
Collaborator
Author
|
Superseded by #11622, which uses a branch owned by this repository. Please continue review there. |
Niels Laute (niels9001)
deleted the
feature/9403-appbarbutton-width-resources
branch
August 25, 2026 08:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #9403
PR Type
Description
Current Behavior
The default 68px width of
AppBarButtonandAppBarToggleButtonis fixed in their styles and cannot be changed through lightweight styling resources.New Behavior
Adds
AppBarButtonWidthandAppBarToggleButtonWidthresources, both defaulting to 68px in the regular and perf2026 styles. Overflow buttons remain auto-sized, and a locally setWidthcontinues to take precedence. API and rendered-width coverage verify default, resource-overridden, overflow, and local-width behavior.Customer Impact
Apps can adjust command button widths through lightweight styling without replacing the control templates.
Regression Potential
The new resources preserve the current defaults and precedence rules.
How Has This Been Tested?
The product controls, core XAML, theme XBF, resource satellites, test app, and test project were previously built. The focused tests built and were discovered; execution was blocked by an activation failure also reproduced on the unchanged baseline.
Screenshots (if appropriate)
Not applicable.