Skip to content

Fix memory leak in PerfServer DelayWorker initialization failure #5213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guhetier merged 3 commits into from
Jul 10, 2025
Merged

Fix memory leak in PerfServer DelayWorker initialization failure #5213

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87c9fb4
Initial plan
Copilot Jul 1, 2025
91841fe
Fix memory leak in DelayWorker initialization failure
Copilot Jul 1, 2025
d519690
Fix DelayWorker cleanup loop to only shutdown initialized workers
Copilot Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/perf/lib/PerfServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,17 @@ PerfServer::Init(

ProcCount = (uint16_t)CxPlatProcCount();
DelayWorkers = new (std::nothrow) DelayWorker[ProcCount];
if (!DelayWorkers) {
WriteOutput("Failed to allocate delay workers.\n");
return QUIC_STATUS_OUT_OF_MEMORY;
}
for (uint16_t i = 0; i < ProcCount; ++i) {
if (!DelayWorkers[i].Initialize(this, i)) {
for (uint16_t j = 0; j < ProcCount; ++j) {
Comment thread
csujedihy marked this conversation as resolved.
Outdated
DelayWorkers[j].Shutdown();
}
delete[] DelayWorkers;
DelayWorkers = nullptr;
WriteOutput("Failed to init delay workers.\n");
return QUIC_STATUS_INTERNAL_ERROR;
}
Expand Down
Loading