Skip to content

CP: Allow Configuration of Stateless Retry Key (#5112) and Fix quictls static assert (#5179)#5216

Merged
anrossi merged 2 commits into
release/2.5from
retry-config-on-release-2.5
Jul 18, 2025
Merged

CP: Allow Configuration of Stateless Retry Key (#5112) and Fix quictls static assert (#5179)#5216
anrossi merged 2 commits into
release/2.5from
retry-config-on-release-2.5

Conversation

@anrossi

@anrossi anrossi commented Jul 2, 2025

Copy link
Copy Markdown
Collaborator

Cherry pick from #5112 and #5179 (build fix)

* Add SetParam interface

* Add API test

* Add documentation

* Add registry read logic.

* Add GetParam only for debug builds

* Write tests for the registry settings

* Require secret and algorithm to change together in registry

---------

Co-authored-by: Nick Banks <nibanks@microsoft.com>
@anrossi
anrossi requested a review from a team as a code owner July 2, 2025 07:24
@anrossi anrossi changed the title CP: Allow Configuration of Stateless Retry Key (#5112) CP: Allow Configuration of Stateless Retry Key (#5112) and Fix quictls static assert (#5179) Jul 2, 2025
@codecov

codecov Bot commented Jul 2, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 96.15385% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.91%. Comparing base (3ba37a3) to head (da9f371).

Files with missing lines Patch % Lines
src/core/library.c 96.73% 3 Missing ⚠️
src/core/partition.c 91.66% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release/2.5    #5216      +/-   ##
===============================================
- Coverage        87.19%   86.91%   -0.28%     
===============================================
  Files               59       59              
  Lines            18058    18155      +97     
===============================================
+ Hits             15745    15779      +34     
- Misses            2313     2376      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sm-msft

sm-msft commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

I think we need to discuss the changes that go into release 2.5 at this time.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, thanks for this. I think this is causing msh3 to fail to build on the latest atm.

@guhetier

Copy link
Copy Markdown
Collaborator

It seems strange to me to have an API change that is going to ship in v2.5.1, which is a patch version.

On the one hand, some changes leading to it have already been cherry-picked. On the other hand, we could also very easily create a v2.6.

Opinions?

@anrossi

anrossi commented Jul 11, 2025

Copy link
Copy Markdown
Collaborator Author

I don't want to break the rules around semantic versioning unless there's a really good reason, but I need to make sure the partners who requested this feature can go with 2.6 or if they need it in 2.5. I think they need it in 2.5.

@anrossi
anrossi merged commit 5a286ea into release/2.5 Jul 18, 2025
324 of 332 checks passed
@anrossi
anrossi deleted the retry-config-on-release-2.5 branch July 18, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants