CP: Allow Configuration of Stateless Retry Key (#5112) and Fix quictls static assert (#5179)#5216
Conversation
* Add SetParam interface * Add API test * Add documentation * Add registry read logic. * Add GetParam only for debug builds * Write tests for the registry settings * Require secret and algorithm to change together in registry --------- Co-authored-by: Nick Banks <nibanks@microsoft.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/2.5 #5216 +/- ##
===============================================
- Coverage 87.19% 86.91% -0.28%
===============================================
Files 59 59
Lines 18058 18155 +97
===============================================
+ Hits 15745 15779 +34
- Misses 2313 2376 +63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think we need to discuss the changes that go into release 2.5 at this time. |
There was a problem hiding this comment.
FYI, thanks for this. I think this is causing msh3 to fail to build on the latest atm.
|
It seems strange to me to have an API change that is going to ship in v2.5.1, which is a patch version. On the one hand, some changes leading to it have already been cherry-picked. On the other hand, we could also very easily create a v2.6. Opinions? |
|
I don't want to break the rules around semantic versioning unless there's a really good reason, but I need to make sure the partners who requested this feature can go with 2.6 or if they need it in 2.5. I think they need it in 2.5. |
Cherry pick from #5112 and #5179 (build fix)