CP: More silo enlightenment (#5220) - v2.4

[csujedihy]

Description

#5220 Attach to the right silo when uninitializing a connection. Otherwise, the security context could be freed in a silo that's not where the context was allocated.

Testing

CI and local repro

Documentation

N/A

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.20%. Comparing base (9e9fbb4) to head (5235302).
Report is 1 commits behind head on release/2.4.

Additional details and impacted files

@@               Coverage Diff               @@
##           release/2.4    #5240      +/-   ##
===============================================
- Coverage        85.94%   85.20%   -0.75%     
===============================================
  Files               56       56              
  Lines            17338    17338              
===============================================
- Hits             14902    14772     -130     
- Misses            2436     2566     +130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[guhetier]

nit: Should we cherry-pick the build fix PRs separately instead of bringing them with other changes?

[csujedihy]

nit: Should we cherry-pick the build fix PRs separately instead of bringing them with other changes?

Probably unnecessary. We won't need that fix anymore as we have gotten rid of v2.3. Also, the build fix can't be simply cherry-picked from 2.5. The code is different and I had to fix it manually.