Log 1-RTT keys in SSLKEYLOG when using OpenSSL#5297
Closed
andrewkdinh wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree company="OpenSSL Corporation" |
Collaborator
|
Thanks for the contribution! |
Contributor
Author
|
Ah, didn’t know about that one. Will close this, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change ensures that all 1-RTT keys are properly logged to the SSLKEYLOGFILE, which was not fully implemented in microsoft/msquic#4959. Without this, some QUIC traffic could not be decrypted during analysis.
Example SSLKEYLOGFILE from running resumption QUIC interop test:
Additionally, this update fixes an unrelated issue where a conditional block for
if opensslwas missing.Testing
Previously, Wireshark was unable to decrypt certain packets in QUIC interop tests due to missing 1-RTT keys in the SSLKEYLOGFILE when using MsQuic built with the OpenSSL backend.
With this fix:
These changes will be validated through the https://github.com/openssl/openssl GitHub Actions CI, which includes interop testing using MsQuic built with OpenSSL backend. Here is a QUIC interop run on my own fork before it is merged to https://github.com/openssl/openssl: https://github.com/andrewkdinh/openssl/actions/runs/16625623943
Fixes openssl/project#1311