Consolidate GOP driver usage for QEMU platforms#1430
Merged
Conversation
The current Q35 platform has been using a legacy cirrus video driver, whereas the SBSA is using a PCI based Bochs display. Given that Q35 also supports the Bochs display, it would make better sense for these platforms to share the same video driver. The Ramfb driver for Q35 is also removed, which was supposed to be another GOP provider somehow. - [x] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? This was tested by booting the Q35 platform to Windows desktop. N/A
vineelko
reviewed
Jun 9, 2026
vineelko
approved these changes
Jun 9, 2026
cfernald
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current Q35 platform has been using a legacy cirrus video driver, whereas the SBSA is using a PCI based Bochs display.
Given that Q35 also supports the Bochs display, it would make better sense for these platforms to share the same video driver.
The Ramfb driver for Q35 is also removed, which was supposed to be another GOP provider somehow.
How This Was Tested
This was tested on both QEMU Q35 and SBSA and verified the video works properly.
Integration Instructions
N/A