Prefer using CMake path variables where available#2208
Open
jaeyoonjung wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the ONNX Runtime (ORT) include/lib path resolution when ORT_HOME is provided, switching from hard-coded include/lib paths to GNUInstallDirs-style variables.
Changes:
- Use
${CMAKE_INSTALL_INCLUDEDIR}/${CMAKE_INSTALL_LIBDIR}underORT_HOME(including the AIX-specificonnxruntimeinclude subdir). - Remove hard-coded
include/libpath assumptions for non-macOS ORT layouts.
jaeyoonjung
force-pushed
the
pr.cmake_paths
branch
from
1dc11fb to
5e84eff
Compare
Contributor
Author
|
@microsoft-github-policy-service agree company="LGE" |
jaeyoonjung
changed the title
jaeyoonjung
force-pushed
the
pr.cmake_paths
branch
3 times, most recently
from
cc1c6e4 to
12db31d
Compare
Try CMAKE_INSTALL_INCLUDEDIR and CMAKE_INSTALL_LIBDIR instead of hardcoded paths 'include' and 'lib' respectively if available. Signed-off-by: Jaeyoon Jung <jaeyoon.jung@lge.com>
jaeyoonjung
force-pushed
the
pr.cmake_paths
branch
from
12db31d to
6453923
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hardcoded paths would fail if the build system uses different include or lib paths.