Skip to content

Add path traversal validation #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apsonawane wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add path traversal validation #2222

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3f195c4
Add path traversal validation
apsonawane Jun 11, 2026
c4f6a7f
Address comments
apsonawane Jun 12, 2026
0d51e5c
Fix pipeline
apsonawane Jun 12, 2026
3d19916
Address comments
apsonawane Jun 12, 2026
cba6cd0
Merge branch 'main' into asonawane/modelcpp
apsonawane Jun 24, 2026
d0d9771
Use std::filesystem locally for custom_ops_library path validation
apsonawane Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/models/model.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,8 +636,18 @@ void Model::CreateSessionOptionsFromConfig(const Config::SessionOptions& config_

std::string custom_library_file_prefix = config_session_options.custom_ops_library.value();

// If relative path, try to resolve using multiple search locations
// Reject absolute paths and any rooted paths (e.g., Windows drive-relative "C:foo.dll"),

@kunal-vaishnavi kunal-vaishnavi Jun 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen a mix of absolute and relative paths used for the path to the custom ops library. Is it possible to support both?

@apsonawane apsonawane Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we now support both absolute and relative paths. However, to prevent arbitrary library loading (e.g., a malicious C:\evil\malware.dll), we validate that the final resolved path falls within one of the trusted directories: the model folder, the EP library directory, or the current working directory. Absolute paths that point outside these locations are rejected. Path traversal (..) is also blocked upfront. This gives users flexibility while maintaining security.

// since rooted paths can override the intended base directory during path concatenation.
fs::path custom_library_path{custom_library_file_prefix};
if (!custom_library_path.is_relative()) {
throw std::runtime_error("custom_ops_library must be a relative path (no root name/drive letter), got: " + custom_library_file_prefix);
}
// Reject path traversal components
if (custom_library_file_prefix.find("..") != std::string::npos) {
throw std::runtime_error("custom_ops_library must not contain path traversal (..): " + custom_library_file_prefix);
}

// If relative path, try to resolve using multiple search locations
if (custom_library_path.is_relative()) {
bool resolved = false;

Expand Down
Loading