ovmm_entry: Remove need for unsafe in tests#3200
Merged
smalis-msft merged 3 commits intomicrosoft:mainfrom Apr 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the need for unsafe in openvmm_entry CLI parsing tests by refactoring the autocache disk-spec parsing so tests can inject a cache-path value instead of mutating process-wide environment variables.
Changes:
- Added
DiskCliKind::parse_autocache(...)helper to parseautocache:[key]:<kind>given a cache path input. - Updated
DiskCliKind’sFromStrimplementation to use the new helper when parsingautocache. - Reworked tests to avoid
std::env::set_var/remove_varand added coverage for key/no-key and missing-cache-path cases.
chris-oo
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file really shouldn't need unsafe, we can just mock out the environment variable instead of actually modifying it.