Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds unit tests to the support/crypto crate using published crypto test vectors to validate AES-256-GCM and XTS-AES-256 implementations across backends.
Changes:
- Add an AES-256-GCM unit test based on a NIST GCM test case.
- Add an XTS-AES-256 unit test intended to be based on IEEE Std 1619-2007 vectors.
- Add
hexas adev-dependencyfor decoding vector inputs in tests.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| support/crypto/src/xts_aes_256/mod.rs | Adds an XTS-AES-256 unit test (currently round-trip based). |
| support/crypto/src/aes_256_gcm/mod.rs | Adds an AES-256-GCM unit test using a NIST vector (ciphertext asserted). |
| support/crypto/Cargo.toml | Adds hex under dev-dependencies for test vector decoding. |
| Cargo.lock | Records hex as a dependency of the crypto crate for tests. |
chris-oo
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some publicly documented test vectors to make sure we have our algos wired up right.