Skip to content

feat(settings): add HVE Core extension to workspace and devcontainer recommendations#226

Open
WilliamBerryiii wants to merge 4 commits intomainfrom
feature/add-hve-core-extension-recommendations
Open

feat(settings): add HVE Core extension to workspace and devcontainer recommendations#226
WilliamBerryiii wants to merge 4 commits intomainfrom
feature/add-hve-core-extension-recommendations

Conversation

@WilliamBerryiii
Copy link
Copy Markdown
Member

@WilliamBerryiii WilliamBerryiii commented Mar 13, 2026

Pull Request

Description

Add HVE Core extension pack (ise-hve-essentials.hve-core-all) to workspace and devcontainer extension recommendations, ensuring consistent tooling for all contributors. Attribute HVE Core in README acknowledgments.

Closes #132

Type of Change

  • 🐛 Bug fix (non-breaking change fixing an issue)
  • ✨ New feature (non-breaking change adding functionality)
  • 💥 Breaking change (fix or feature causing existing functionality to change)
  • 📚 Documentation update
  • 🏗️ Infrastructure change (Terraform/IaC)
  • ♻️ Refactoring (no functional changes)

Component(s) Affected

  • deploy/000-prerequisites - Azure subscription setup
  • deploy/001-iac - Terraform infrastructure
  • deploy/002-setup - OSMO control plane / Helm
  • deploy/004-workflow - Training workflows
  • src/training - Python training scripts
  • docs/ - Documentation

Testing Performed

  • Terraform plan reviewed (no unexpected changes)
  • Terraform apply tested in dev environment
  • Training scripts tested locally with Isaac Sim
  • OSMO workflow submitted successfully
  • Smoke tests passed (smoke_test_azure.py)

Additional validation:

  • npm run spell-check — 419 files, 0 issues
  • npm run lint:md — 93 files, 0 errors
  • JSON syntax validated for both .vscode/extensions.json and .devcontainer/devcontainer.json

Documentation Impact

  • No documentation changes needed
  • Documentation updated in this PR
  • Documentation issue filed

Bug Fix Checklist

N/A — this is a feature PR, not a bug fix.

Checklist

…recommendations

- update extension ID from hve-core to hve-core-all in .vscode/extensions.json
- add ise-hve-essentials.hve-core-all to .devcontainer/devcontainer.json extensions
- add Built with HVE Core attribution to README.md acknowledgments

🧩 - Generated by Copilot
@WilliamBerryiii WilliamBerryiii requested a review from a team as a code owner March 13, 2026 22:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 13, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 74d82fe.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.46%. Comparing base (acfe20d) to head (74d82fe).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   50.46%   50.46%           
=======================================
  Files         267      267           
  Lines       18098    18098           
  Branches     1855     1903   +48     
=======================================
  Hits         9134     9134           
  Misses       8674     8674           
  Partials      290      290           
Flag Coverage Δ *Carryforward flag
pester 81.96% <ø> (ø)
pytest 6.89% <ø> (ø) Carriedforward from db8acab
pytest-dataviewer 61.97% <ø> (ø)
vitest 50.72% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

"GitHub.copilot@prerelease",
"GitHub.copilot-chat@prerelease"
"GitHub.copilot-chat@prerelease",
"ise-hve-essentials.hve-core-all"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont want hve-core-all, just hve-core please, unless we want others with it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this ALL under the theory that we'd want to be able to support teams with being able to run the full project planning through platform building through to platform operations lifecycle in the context of the accelerator itself. There's also the work on the accelerator (which would benefit from the full library), we also have DS components, Security concerns, RAI, programming/scripting, etc. ... by the time we support all the persona using/contributing to the accelerator ... we need all of HVE Core.

"ms-python.vscode-pylance",
"ms-python.python",
"ise-hve-essentials.hve-core",
"ise-hve-essentials.hve-core-all",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, not hve-core-all just hve-core

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

Copy link
Copy Markdown
Contributor

@katriendg katriendg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is the collection we need, also prevents from having duplicate items for some of the agents which are across more than one collection.

@WilliamBerryiii
Copy link
Copy Markdown
Member Author

I believe this is the collection we need, also prevents from having duplicate items for some of the agents which are across more than one collection.

I'll wait for @agreaves-ms to chime back in ... but I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add HVE Core extension to workspace recommendations and devcontainer

5 participants