feat(infrastructure): enable optional AML diagnostic logs#400
Open
fbeltrao wants to merge 2 commits intomicrosoft:mainfrom
Open
feat(infrastructure): enable optional AML diagnostic logs#400fbeltrao wants to merge 2 commits intomicrosoft:mainfrom
fbeltrao wants to merge 2 commits intomicrosoft:mainfrom
Conversation
- add AML workspace diagnostic setting behind a default-off Terraform flag - update Terraform tests, example tfvars, and docs references 🔒 - Generated by Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
=======================================
Coverage 50.46% 50.46%
=======================================
Files 267 267
Lines 18098 18098
Branches 1855 1855
=======================================
Hits 9134 9134
Misses 8674 8674
Partials 290 290
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
katriendg
approved these changes
Apr 7, 2026
| log_analytics_workspace_id = azurerm_log_analytics_workspace.main.id | ||
|
|
||
| enabled_log { | ||
| category_group = "allLogs" |
Contributor
There was a problem hiding this comment.
No metric {} block: the azurerm_monitor_diagnostic_setting omits a metric {} block. Current provider version handles this silently, but adding metric { category = "AllMetrics" enabled = false } makes the intent explicit and avoids future deprecation warnings.
- add explicit disabled diagnostic metric block for AML workspace settings - align with PR review feedback while preserving passing terraform tests �� - Generated by Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #399
Enable an opt-in AML workspace diagnostic setting that forwards all AML resource logs to the platform Log Analytics workspace. Thread
should_enable_aml_diagnostic_logsfrom the root module intomodule.platform, createazurerm_monitor_diagnostic_setting.ml_workspace_logsinmodules/platform/azureml.tf, and document the new flag in the Terraform reference files and example tfvars.Add Terraform tests that verify the diagnostic setting is absent by default, present when enabled, and configured with the standard name plus
category_group = "allLogs".Type of Change
Component(s) Affected
infrastructure/terraform/prerequisites/- Azure subscription setupinfrastructure/terraform/- Terraform infrastructureinfrastructure/setup/- OSMO control plane / Helmworkflows/- Training and evaluation workflowstraining/- Training pipelines and scriptsdocs/- DocumentationTesting Performed
planreviewed (no unexpected changes)applytested in dev environmentsmoke_test_azure.py)Documentation Impact
Bug Fix Checklist
Complete this section for bug fix PRs. Skip for other contribution types.
Checklist