Skip to content

test: expand telemetry coverage#439

Open
karthiknadig wants to merge 1 commit intomainfrom
test/issue-389-telemetry
Open

test: expand telemetry coverage#439
karthiknadig wants to merge 1 commit intomainfrom
test/issue-389-telemetry

Conversation

@karthiknadig
Copy link
Copy Markdown
Member

Adds 13 new unit tests to pet-telemetry (from 4 to 17 total).

New coverage:

  • are_versions_different(): same version, different patch/minor, version suffixes, non-version strings, empty strings
  • Executable mismatch detection and None handling
  • Executable not in symlinks detection (accounts for builder auto-adding exe to symlinks)
  • Architecture mismatch detection and None handling
  • Version mismatch end-to-end

Fixes #389

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Performance Report (Linux) ➖

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 1ms 1ms 0ms 1ms N/A%
Full Refresh 55ms 765ms 53ms 2ms 0%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Test Coverage Report (Linux)

Metric Value
Current Coverage 75.8%
Base Branch Coverage 75.6%
Delta .2% ✅

Coverage increased! Great work!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Test Coverage Report (Windows)

Metric Value
Current Coverage 72.73%
Base Branch Coverage 72.49%
Delta 0.24% ✅

Coverage increased! Great work!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Performance Report (macOS)

Metric PR (P50) PR (P95) Baseline (P50) Delta
Server Startup 86ms 851ms 85ms 1ms
Full Refresh 140ms 36354ms 175ms -35ms

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Performance Report (Windows) ✅

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 9ms 12ms 11ms -2ms -18.2%
Full Refresh 148ms 331ms 202ms -54ms -26.7%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@karthiknadig karthiknadig force-pushed the test/issue-389-telemetry branch from fba9eea to 11e35fa Compare April 23, 2026 15:48
@karthiknadig karthiknadig marked this pull request as ready for review April 23, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coverage: ranked plan to move workspace coverage toward 90%

2 participants