Skip to content

test: add unit tests for pet-windows-store crate (Fixes #389)#443

Open
karthiknadig wants to merge 1 commit intomainfrom
test/issue-389-windows-store
Open

test: add unit tests for pet-windows-store crate (Fixes #389)#443
karthiknadig wants to merge 1 commit intomainfrom
test/issue-389-windows-store

Conversation

@karthiknadig
Copy link
Copy Markdown
Member

Add 9 new unit tests to pet-windows-store (19 total, up from 10):

  • Sync from None source clears shared state
  • Sync is idempotent
  • is_windows_app_folder case insensitivity
  • is_windows_app_folder rejects single-char input
  • normalize_for_comparison: extended prefix, UNC prefix, plain path
  • CachedStoreEnvironment with empty/None symlinks
  • try_from returns None on Unix

Fixes #389

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Performance Report (Linux) ➖

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 1ms 1ms 0ms 1ms N/A%
Full Refresh 55ms 356ms 53ms 2ms 0%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Test Coverage Report (Linux)

Metric Value
Current Coverage 75.8%
Base Branch Coverage 75.6%
Delta .2% ✅

Coverage increased! Great work!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Performance Report (macOS)

Metric PR (P50) PR (P95) Baseline (P50) Delta
Server Startup 46ms 475ms 85ms -39ms
Full Refresh 92ms 25943ms 175ms -83ms

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Performance Report (Windows) ✅

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 12ms 13ms 11ms 1ms 9.1%
Full Refresh 184ms 391ms 202ms -18ms -8.9%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Test Coverage Report (Windows)

Metric Value
Current Coverage 72.62%
Base Branch Coverage 72.49%
Delta 0.13% ✅

Coverage increased! Great work!

@karthiknadig karthiknadig force-pushed the test/issue-389-windows-store branch from c4d9b7c to ccb7843 Compare April 23, 2026 15:48
@karthiknadig karthiknadig marked this pull request as ready for review April 23, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coverage: ranked plan to move workspace coverage toward 90%

2 participants