-
Notifications
You must be signed in to change notification settings - Fork 171
Adaptive Profile support for CPU-full-state and Clifford simulators #3086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
orpuente-MS
wants to merge
12
commits into
main
Choose a base branch
from
oscarpuente/adaptive-support-for-cpu-simulators
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1534e80
make bytecode generic for 32 and 64 bit word size
orpuente-MS 18ed36d
[wip] add cpu bytecode interpreter
orpuente-MS 88cd287
cargo fmt
orpuente-MS b2634d3
better python signatures
orpuente-MS 37bb014
add back operands laoyout comment in _emit_switch
orpuente-MS c5cc017
remove `s`, `s_adj`, and `z` noise overriding
orpuente-MS 20007aa
make `VOID_RETURN` sentil value depend on bytecode word width
orpuente-MS 11eac42
cleanup runtime.rs
orpuente-MS 78134d3
move `z`, `s`, `s_adj` inherit-noise-from-rz logic to device specific…
orpuente-MS 4c32c72
fix dynamic angles
orpuente-MS 590d8b8
better comments
orpuente-MS 1377d9b
Merge branch 'main' into oscarpuente/adaptive-support-for-cpu-simulators
orpuente-MS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic was previously in
cpu_simulators.rs, but it is very specific to the device; now that therun_qirfunction is being used more widely, it makes sense to move it here. Also, the GPU simulator was missing this logic, putting it here makes it common for all simulators available to theNeutralAtomDeviceclass