Skip to content

fix: hubble not showing services and app names on relay and ui - #1754

Merged
Mereta (mereta) merged 1 commit into
mainfrom
fix/hubble
Dec 18, 2025
Merged

fix: hubble not showing services and app names on relay and ui#1754
Mereta (mereta) merged 1 commit into
mainfrom
fix/hubble

Conversation

@nddq

Copy link
Copy Markdown
Member

Description

This PR fixes the issue where service IPs are not being resolved in the Hubble relay's flow logs and app names are not showing up on Hubble UI. This was done by introducing a service cache and a label cache via the service and cilium identity controllers.

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

image image

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the issue where service IPs are not being resolved in the Hubble relay's flow logs and app names are not showing up on Hubble UI by introducing a service cache and a label cache via the service and cilium identity controllers.

  • Implements service and CiliumIdentity reconcilers using controller-runtime to maintain in-memory caches
  • Replaces previous incomplete service decoder with functional service resolution from IP addresses
  • Adds label resolution for security identities to display app names in Hubble UI

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/k8s/cell_linux.go Enables operator-managed CIDs in cache allocator configuration
pkg/hubble/resources/service_linux.go Implements service reconciler for caching service IP to name mappings
pkg/hubble/resources/service_linux_test.go Comprehensive test coverage for service reconciler functionality
pkg/hubble/resources/ciliumidentity_linux.go Implements CiliumIdentity reconciler for caching labels by security identity
pkg/hubble/resources/ciliumidentity_linux_test.go Test coverage for CiliumIdentity reconciler operations
pkg/hubble/resources/cell_linux.go Hive cell module configuration for resource reconcilers
pkg/hubble/parser/seven/parser_linux.go Updates parser to use new service reconciler and label cache
pkg/hubble/parser/parser_linux.go Refactors parser constructor to use dependency injection
pkg/hubble/parser/layer34/parser_linux.go Updates layer34 parser to use new decoders
pkg/hubble/common/decoder_linux.go Adds LabelCache interface and removes incomplete service decoder
deploy/hubble/manifests/controller/helm/retina/values.yaml Updates Hubble UI image versions and repositories
cmd/hubble/daemon_linux.go Adds Cilium API v2 scheme registration
cmd/hubble/cells_linux.go Integrates resource cell and updates parser dependency injection
Makefile Increases golangci-lint concurrency for better performance
Comments suppressed due to low confidence (4)

pkg/hubble/resources/ciliumidentity_linux_test.go:283

  • The function parameter should be named 't' following Go testing conventions.
func TestCiliumIdentityReconciler_removeIdentityFromCache_InvalidName(*testing.T) {

pkg/hubble/resources/ciliumidentity_linux_test.go:294

  • The function parameter should be named 't' following Go testing conventions.
func TestCiliumIdentityReconciler_removeIdentityFromCache_NotInCache(*testing.T) {

pkg/hubble/resources/service_linux.go:68

  • [nitpick] The error message should be more specific about what operation failed, e.g., 'failed to retrieve Service from Kubernetes API'.
		return ctrl.Result{}, errors.Wrap(err, "failed to get Service")

pkg/hubble/resources/ciliumidentity_linux.go:73

  • [nitpick] The error message should be more specific about what operation failed, e.g., 'failed to retrieve CiliumIdentity from Kubernetes API'.
		return ctrl.Result{}, errors.Wrap(err, "failed to get CiliumIdentity")

@nddq
Quang Nguyen (nddq) force-pushed the fix/hubble branch 2 times, most recently from 61d3d60 to ec8899a Compare July 31, 2025 14:26
@whatnick

Copy link
Copy Markdown
Contributor

Looking forward to this to improve the hubble experience.

@sfenzke

Copy link
Copy Markdown

Is there a roadmap when this will be released?

@VincentS

Copy link
Copy Markdown

Any update on this PR Quang Nguyen (@nddq) ?

@nddq

Copy link
Copy Markdown
Member Author

Vincent Schwarzer (@VincentS) hey, sorry for the delay as I've been busy with other commitments, I've asked the internal team for reviews.

@rredziak

Copy link
Copy Markdown

Hello Quang Nguyen (@nddq), Anubhab Majumdar (@anubhabMajumdar) and Team,

any update on this PR?

@github-actions

Copy link
Copy Markdown

This PR will be closed in 7 days due to inactivity.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/hubble/resources/ciliumidentity_linux_test.go Outdated
Comment thread pkg/hubble/resources/ciliumidentity_linux_test.go Outdated
Comment thread pkg/hubble/resources/ciliumidentity_linux_test.go Outdated
Comment thread deploy/hubble/manifests/controller/helm/retina/values.yaml Outdated
Comment thread pkg/hubble/resources/cell_linux.go Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/hubble/resources/service_linux.go
Comment thread pkg/hubble/resources/service_linux.go
Comment thread pkg/hubble/resources/ciliumidentity_linux.go Outdated
Comment thread pkg/hubble/resources/service_linux.go
Comment thread pkg/hubble/resources/ciliumidentity_linux.go
Comment thread pkg/hubble/common/decoder_linux.go
Comment thread pkg/hubble/common/decoder_linux.go
This PR fixes the issue where service IPs are not being resolved in the
Hubble relay's flow logs and app names are not showing up on Hubble UI.
This was done by introducing a service cache and a label cache via the
service and cilium identity controllers.

Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>

@SRodi Simone Rodigari (SRodi) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is a long awaited great fix Quang Nguyen (@nddq), thanks a lot!

@mereta Mereta (mereta) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated this locally all looking good! Thanks Quang Nguyen (@nddq)!

image

@mereta
Mereta (mereta) added this pull request to the merge queue Dec 18, 2025
Merged via the queue into main with commit fffdf1c Dec 18, 2025
31 checks passed
@mereta
Mereta (mereta) deleted the fix/hubble branch December 18, 2025 16:05
@amitmavgupta

Copy link
Copy Markdown

Mereta (@mereta) is there going to be a new retina release with this fix? would that be available with 1.0.3?

@mereta

Copy link
Copy Markdown
Contributor

Mereta (@mereta) is there going to be a new retina release with this fix? would that be available with 1.0.3?

Yes 1.0.3 will have this. We definitely still need a Documentation update for this.

@jonasz-lasut

Copy link
Copy Markdown

Hi Mereta (@mereta) is there a approximate date for 1.0.3 release?

@nddq

Copy link
Copy Markdown
Member Author

Jonasz Łasut-Balcerzak (@jonasz-lasut) https://github.com/microsoft/retina/releases/tag/v1.0.3 we've just released it :)

Laksh (lakshk98) pushed a commit to lakshk98/retina that referenced this pull request Aug 4, 2026
…soft#1754)

# Description

This PR fixes the issue where service IPs are not being resolved in the
Hubble relay's flow logs and app names are not showing up on Hubble UI.
This was done by introducing a service cache and a label cache via the
service and cilium identity controllers.

## Related Issue

If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

<img width="3318" height="1124" alt="image"
src="https://github.com/user-attachments/assets/97ba0a73-5938-4ecc-aae5-8d25e976ded7"
/>
<img width="2995" height="1065" alt="image"
src="https://github.com/user-attachments/assets/6c44a80a-7e1e-4b42-9378-705d407d3dc4"
/>

## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.

Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
Laksh (lakshk98) pushed a commit to lakshk98/retina that referenced this pull request Aug 4, 2026
…soft#1754)

# Description

This PR fixes the issue where service IPs are not being resolved in the
Hubble relay's flow logs and app names are not showing up on Hubble UI.
This was done by introducing a service cache and a label cache via the
service and cilium identity controllers.

## Related Issue

If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

<img width="3318" height="1124" alt="image"
src="https://github.com/user-attachments/assets/97ba0a73-5938-4ecc-aae5-8d25e976ded7"
/>
<img width="2995" height="1065" alt="image"
src="https://github.com/user-attachments/assets/6c44a80a-7e1e-4b42-9378-705d407d3dc4"
/>

## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.

Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hubble UI does not show namespace and app name Enrich flows with Service name and namespace

10 participants