fix: Update api group naming to retina.sh - #1961
Closed
kamilprz wants to merge 2 commits into
Closed
Conversation
kamilprz
requested review from
Anubhab Majumdar (anubhabMajumdar) and
Steven Nguyen (snguyen64)
December 4, 2025 14:05
kamilprz
force-pushed
the
kamilp/helm-roles
branch
from
December 4, 2025 14:22
5e4a576 to
48ad0c1
Compare
Signed-off-by: Kamil <kamil.prz@gmail.com>
kamilprz
force-pushed
the
kamilp/helm-roles
branch
from
December 8, 2025 12:23
48ad0c1 to
9bb194b
Compare
|
This PR will be closed in 7 days due to inactivity. |
|
Pull request closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was still mentions of
retina.iowithin the cluster role files for agent and operator. This PR updates those toretina.sh.Related Issue
#1936
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Applying changes to helm chart shows that cluster role is now retina.sh
Listing captures
With
retina.ioapigroupWith
retina.shapigroupThe retina agent will still return no, as it doesn't have the
capturesresources defined in its clusterrole.