fix(helm): remove unused capture RBAC from hubble operator clusterrole - #2420
Merged
Quang Nguyen (nddq) merged 5 commits intoAug 21, 2026
Merged
Conversation
Sébastien Larivière (slariviere)
requested review from
Quang Nguyen (nddq) and
orangejuice
June 5, 2026 21:16
Contributor
Author
|
orangejuice Quang Nguyen (@nddq), can we do anything to move this PR forward? |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes unused Hubble operator permissions to enforce least-privilege RBAC.
Changes:
- Removes
batch/jobspermissions. - Removes
retina.sh/capturespermissions.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Quang Nguyen (nddq)
enabled auto-merge
August 21, 2026 14:13
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 21, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 21, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Capture CRD is not shipped with this chart,
retina.sh/capturespermissions are unused and constitute excess privilege. The same goes for thebatch/jobssince they are used for that reason.Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.