Skip to content

deps: reduce docker cooldown to 2 days - #2666

Merged
Quang Nguyen (nddq) merged 1 commit into
mainfrom
nddq/dependabot-docker-cooldown
Aug 18, 2026
Merged

deps: reduce docker cooldown to 2 days#2666
Quang Nguyen (nddq) merged 1 commit into
mainfrom
nddq/dependabot-docker-cooldown

Conversation

@nddq

Copy link
Copy Markdown
Member

Description

MCR rebuilds the base images to ship CVE fixes, so the cooldown delays the patches this repo needs. Nothing bypasses it. Dependabot does not scan image contents, so base image CVEs never raise a dependabot security alert. govulncheck and Trivy report them instead.

The delay is measurable:

A long window also starves a frequently rebuilt tag. MCR re-pushed 1.26.6 on 17 August, which reset the window to 24 August.

Two days still covers a same-day bad push. The groups, the weekly interval, and the full image build on every PR already limit the risk. gomod and npm keep 7 days.

Related Issue

N/A.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally. (N/A — dependabot runs server-side.)
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

N/A.

Additional Notes

N/A.

MCR rebuilds the base images to ship CVE fixes, so the cooldown delays
the patches this repo needs. Nothing bypasses it. Dependabot does not
scan image contents, so base image CVEs never raise a dependabot
security alert. govulncheck and Trivy report them instead.

A long window also starves a frequently rebuilt tag. MCR re-pushed the
1.26.6 tag 3 days after the first push, which reset the window from 21
to 24 August.

Two days still covers a same-day bad push. gomod and npm keep 7 days.

Signed-off-by: Quang Nguyen <28567936+nddq@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Retina Code Coverage Report

Total coverage no change

Increased diff

Impacted Files Coverage
pkg/controllers/daemon/namespace/namespace_controller.go 76.24% ... 78.46% (2.22%) ⬆️

@nddq
Quang Nguyen (nddq) added this pull request to the merge queue Aug 18, 2026
Merged via the queue into main with commit da03a01 Aug 18, 2026
31 of 43 checks passed
@nddq
Quang Nguyen (nddq) deleted the nddq/dependabot-docker-cooldown branch August 18, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants