Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds SQL Database CMK revalidation and discovery of restorable deleted SQL databases, and includes minor formatting cleanup in existing modules.
Changes:
- Added
revalidate_cmkto trigger CMK revalidation for a SQL database item. - Added
list_restorable_deleted_databasesto list deleted SQL databases that are still restorable. - Minor formatting/readability tweaks in report and admin helpers.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/sempy_labs/sql_database/_items.py | Adds CMK revalidation API wrapper and a new listing API wrapper for restorable deleted databases. |
| src/sempy_labs/sql_database/init.py | Exports the two new SQL database helpers as part of the public module API. |
| src/sempy_labs/report/_paginated.py | Minor formatting change (single-line resolve_item_id call). |
| src/sempy_labs/admin/_basic_functions.py | Formatting cleanup for workspace rows construction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.