Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates list_data_access_roles to support multiple API “views” (rules vs membership), expands returned columns, and includes some minor formatting cleanups.
Changes:
- Add
viewparameter tolist_data_access_rolesand branch parsing/output columns based on the selected view. - Include additional role metadata fields (
Role Id,Etag,Kind) in the returned DataFrame. - Apply small formatting-only refactors in report/admin helpers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/sempy_labs/report/_paginated.py | Formatting simplification for resolve_item_id call. |
| src/sempy_labs/admin/_basic_functions.py | Formatting cleanup of rows.append({...}) block. |
| src/sempy_labs/_data_access_security.py | Adds view support and reshapes role/membership/rules parsing + output schema. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.