Conversation
|
As part of updating the dependencies in Packages.props we require that any PRs opened also verify that Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR
|
Packages.props
Outdated
| <PackageReference Update="Microsoft.SqlServer.DacFx" Version="170.3.93" /> | ||
| <PackageReference Update="Microsoft.SqlPackage.Core" Version="0.1.75-preview" /> | ||
| <PackageReference Update="Microsoft.SqlServer.DacFx.Projects" Version="0.5.20-preview" /> | ||
| <PackageReference Update="Microsoft.SqlServer.DacFx.Projects" Version="0.5.22-preview" /> |
There was a problem hiding this comment.
there's a problem with SQL build SDK 2.1.0 https://www.nuget.org/packages/Microsoft.Build.Sql/2.1.0 maybe hold on for now
There was a problem hiding this comment.
Done, removed the projects bump, will do a separate vbump for it
a045054
|
The change looks fine, but please coordinate with Leila whether regarding whether we should take this bump now. |
|
We have already upgraded the dacfx version to the last stable preview version before the release, upgrading this GA wouldn't cause any issues, will check with @llali once agian. |
Pull Request Template – SQL Tools Service
Description
This PR:
Code Changes Checklist
dotnet test)Reviewers: Please read our reviewer guidelines