Skip to content

VBump DacFx and SqlProjects#2582

Merged
ssreerama merged 2 commits intomainfrom
sai/vBump_dacfx_BuildSql
Feb 12, 2026
Merged

VBump DacFx and SqlProjects#2582
ssreerama merged 2 commits intomainfrom
sai/vBump_dacfx_BuildSql

Conversation

@ssreerama
Copy link
Copy Markdown
Contributor

@ssreerama ssreerama commented Feb 12, 2026

Pull Request Template – SQL Tools Service

Description

This PR:

  • Upgrades below packages
    • Microsoft.SqlServer.DacFx to Version="170.3.93"
      • upgrading to GA version

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (dotnet test)
  • Code follows contributing guidelines
  • Logging/telemetry updated if relevant
  • No protocol or behavioral regressions

Reviewers: Please read our reviewer guidelines

@github-actions
Copy link
Copy Markdown

As part of updating the dependencies in Packages.props we require that any PRs opened also verify that
they've done the following checks.

Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR

  • Built and tested the change locally to validate that the update doesn't cause any regressions and fixes the issues intended
  • Tested changes on all major platforms
    • Windows
    • Linux
    • Mac
  • Check the source repo for any open issues with the release being updated to (if available)

@ssreerama ssreerama self-assigned this Feb 12, 2026
Benjin
Benjin previously approved these changes Feb 12, 2026
llali
llali previously approved these changes Feb 12, 2026
lewis-sanchez
lewis-sanchez previously approved these changes Feb 12, 2026
Packages.props Outdated
<PackageReference Update="Microsoft.SqlServer.DacFx" Version="170.3.93" />
<PackageReference Update="Microsoft.SqlPackage.Core" Version="0.1.75-preview" />
<PackageReference Update="Microsoft.SqlServer.DacFx.Projects" Version="0.5.20-preview" />
<PackageReference Update="Microsoft.SqlServer.DacFx.Projects" Version="0.5.22-preview" />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a problem with SQL build SDK 2.1.0 https://www.nuget.org/packages/Microsoft.Build.Sql/2.1.0 maybe hold on for now

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, removed the projects bump, will do a separate vbump for it

@kburtram
Copy link
Copy Markdown
Member

The change looks fine, but please coordinate with Leila whether regarding whether we should take this bump now.

@ssreerama
Copy link
Copy Markdown
Contributor Author

We have already upgraded the dacfx version to the last stable preview version before the release, upgrading this GA wouldn't cause any issues, will check with @llali once agian.

@ssreerama ssreerama merged commit b36fbc6 into main Feb 12, 2026
5 of 6 checks passed
@ssreerama ssreerama deleted the sai/vBump_dacfx_BuildSql branch February 12, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants