Skip to content

Remove URI escaping from workspace service. #2588

Merged
aasimkhan30 merged 4 commits intomainfrom
aasim/fix/uriEscaping
Feb 19, 2026
Merged

Remove URI escaping from workspace service. #2588
aasimkhan30 merged 4 commits intomainfrom
aasim/fix/uriEscaping

Conversation

@aasimkhan30
Copy link
Copy Markdown
Contributor

@aasimkhan30 aasimkhan30 commented Feb 19, 2026

Description

Follow up to PR in vscode-mssql, remove escaping from file URI. microsoft/vscode-mssql#21229

Unfortunately, we were still doing that over here which broke query execution as the execution service was not able to find a URI match to get the SQL text.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (dotnet test)
  • Code follows contributing guidelines
  • Logging/telemetry updated if relevant
  • No protocol or behavioral regressions

Reviewers: Please read our reviewer guidelines

caohai
caohai previously approved these changes Feb 19, 2026
lewis-sanchez
lewis-sanchez previously approved these changes Feb 19, 2026
@aasimkhan30 aasimkhan30 dismissed stale reviews from lewis-sanchez and caohai via 9ad8eda February 19, 2026 19:36
@github-actions
Copy link
Copy Markdown

As part of updating the dependencies in Packages.props we require that any PRs opened also verify that
they've done the following checks.

Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR

  • Built and tested the change locally to validate that the update doesn't cause any regressions and fixes the issues intended
  • Tested changes on all major platforms
    • Windows
    • Linux
    • Mac
  • Check the source repo for any open issues with the release being updated to (if available)

@aasimkhan30 aasimkhan30 merged commit 27cc293 into main Feb 19, 2026
6 checks passed
@aasimkhan30 aasimkhan30 deleted the aasim/fix/uriEscaping branch February 19, 2026 20:47
@caohai caohai restored the aasim/fix/uriEscaping branch February 20, 2026 22:29
@caohai caohai deleted the aasim/fix/uriEscaping branch February 20, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants