Conversation
Reintroduce the updated Scriptoria binaries and dependency versions after the net10 migration.
|
As part of updating the dependencies in Packages.props we require that any PRs opened also verify that Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR
|
There was a problem hiding this comment.
Pull request overview
Reintroduces updated Scriptoria-related reference binaries and aligns dependency versions after the net10 migration, while adjusting Copilot/Scriptoria initialization behavior in ServiceLayer.
Changes:
- Removes the
SqlCopilotCommonproject reference fromMicrosoft.SqlTools.ServiceLayer.csproj. - Updates Copilot conversation initialization to register
ToolsetFactoryand set an execution-context flag disablingagents.md. - Bumps central package versions for
Microsoft.SemanticKernel,OpenAI, andSystem.ClientModel, and updates Scriptoria-relatedbin/refDLLs.
Reviewed changes
Copilot reviewed 3 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.SqlTools.ServiceLayer/Microsoft.SqlTools.ServiceLayer.csproj | Removes SqlCopilotCommon reference while keeping Scriptoria-related references for net10 build. |
| src/Microsoft.SqlTools.ServiceLayer/Copilot/CopilotConversationManager.cs | Updates DI registrations and cartridge context settings during Copilot/Scriptoria initialization. |
| Packages.props | Updates centrally-managed versions for SK/OpenAI/System.ClientModel. |
| bin/ref/SqlScriptoriaCommon.dll | Updates Scriptoria common reference binary. |
| bin/ref/SqlCopilotCommon.dll | Adds/updates SqlCopilot common reference binary. |
| bin/ref/ScriptoriaCommonDefs.dll | Updates Scriptoria common defs reference binary. |
Comments suppressed due to low confidence (1)
src/Microsoft.SqlTools.ServiceLayer/Microsoft.SqlTools.ServiceLayer.csproj:52
SqlCopilotCommonreference was removed from this project, butbin/ref/SqlCopilotCommon.dllis still being added/updated in this PR and appears to be unreferenced by any .csproj in the repo. If it’s no longer needed, please remove the binary to avoid carrying unused artifacts; if it is required at build/runtime, add an explicit reference/copy step so the dependency is discoverable and consistent.
<ItemGroup>
<Reference Include="ScriptoriaCommonDefs">
<HintPath>..\..\bin\ref\ScriptoriaCommonDefs.dll</HintPath>
</Reference>
<Reference Include="Scriptoria">
<HintPath>..\..\bin\ref\Scriptoria.dll</HintPath>
</Reference>
<Reference Include="SqlScriptoria">
<HintPath>..\..\bin\ref\SqlScriptoria.dll</HintPath>
</Reference>
<Reference Include="SqlScriptoriaCommon">
<HintPath>..\..\bin\ref\SqlScriptoriaCommon.dll</HintPath>
</Reference>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Reintroduce the updated Scriptoria binaries and dependency versions after the net10 migration.
Code Changes Checklist
dotnet test)Reviewers: Please read our reviewer guidelines