Skip to content

Restore Scriptoria bump on net10#2650

Merged
caohai merged 2 commits intomainfrom
hacao/reapply-scriptoria-bump-net10
Apr 9, 2026
Merged

Restore Scriptoria bump on net10#2650
caohai merged 2 commits intomainfrom
hacao/reapply-scriptoria-bump-net10

Conversation

@caohai
Copy link
Copy Markdown
Member

@caohai caohai commented Apr 8, 2026

Description

Reintroduce the updated Scriptoria binaries and dependency versions after the net10 migration.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (dotnet test)
  • Code follows contributing guidelines
  • Logging/telemetry updated if relevant
  • No protocol or behavioral regressions

Reviewers: Please read our reviewer guidelines

Reintroduce the updated Scriptoria binaries and dependency versions after the net10 migration.
Copilot AI review requested due to automatic review settings April 8, 2026 20:26
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

As part of updating the dependencies in Packages.props we require that any PRs opened also verify that
they've done the following checks.

Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR

  • Built and tested the change locally to validate that the update doesn't cause any regressions and fixes the issues intended
  • Tested changes on all major platforms
    • Windows
    • Linux
    • Mac
  • Check the source repo for any open issues with the release being updated to (if available)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reintroduces updated Scriptoria-related reference binaries and aligns dependency versions after the net10 migration, while adjusting Copilot/Scriptoria initialization behavior in ServiceLayer.

Changes:

  • Removes the SqlCopilotCommon project reference from Microsoft.SqlTools.ServiceLayer.csproj.
  • Updates Copilot conversation initialization to register ToolsetFactory and set an execution-context flag disabling agents.md.
  • Bumps central package versions for Microsoft.SemanticKernel, OpenAI, and System.ClientModel, and updates Scriptoria-related bin/ref DLLs.

Reviewed changes

Copilot reviewed 3 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Microsoft.SqlTools.ServiceLayer/Microsoft.SqlTools.ServiceLayer.csproj Removes SqlCopilotCommon reference while keeping Scriptoria-related references for net10 build.
src/Microsoft.SqlTools.ServiceLayer/Copilot/CopilotConversationManager.cs Updates DI registrations and cartridge context settings during Copilot/Scriptoria initialization.
Packages.props Updates centrally-managed versions for SK/OpenAI/System.ClientModel.
bin/ref/SqlScriptoriaCommon.dll Updates Scriptoria common reference binary.
bin/ref/SqlCopilotCommon.dll Adds/updates SqlCopilot common reference binary.
bin/ref/ScriptoriaCommonDefs.dll Updates Scriptoria common defs reference binary.
Comments suppressed due to low confidence (1)

src/Microsoft.SqlTools.ServiceLayer/Microsoft.SqlTools.ServiceLayer.csproj:52

  • SqlCopilotCommon reference was removed from this project, but bin/ref/SqlCopilotCommon.dll is still being added/updated in this PR and appears to be unreferenced by any .csproj in the repo. If it’s no longer needed, please remove the binary to avoid carrying unused artifacts; if it is required at build/runtime, add an explicit reference/copy step so the dependency is discoverable and consistent.
  <ItemGroup>
    <Reference Include="ScriptoriaCommonDefs">
      <HintPath>..\..\bin\ref\ScriptoriaCommonDefs.dll</HintPath>
    </Reference>
    <Reference Include="Scriptoria">
      <HintPath>..\..\bin\ref\Scriptoria.dll</HintPath>
    </Reference>    
    <Reference Include="SqlScriptoria">
      <HintPath>..\..\bin\ref\SqlScriptoria.dll</HintPath>
    </Reference>
    <Reference Include="SqlScriptoriaCommon">
      <HintPath>..\..\bin\ref\SqlScriptoriaCommon.dll</HintPath>
    </Reference>

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@caohai caohai merged commit a716456 into main Apr 9, 2026
7 checks passed
@caohai caohai deleted the hacao/reapply-scriptoria-bump-net10 branch April 9, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants