[dbus-cxx] add new port #47617
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| vcpkg_check_linkage(ONLY_DYNAMIC_LIBRARY) | ||
|
|
||
| vcpkg_from_github( | ||
| OUT_SOURCE_PATH SOURCE_PATH | ||
| REPO dbus-cxx/dbus-cxx | ||
| REF "${VERSION}" | ||
| SHA512 ad6551d03d0c7d499e9f0c6d77584e39d361a1464017be3c40c237d4c43306ad0ffb49b52c06b89cd62ec7346ebcb29f3d166a31b245fd978159e337a08ebafb | ||
| HEAD_REF master | ||
| ) | ||
|
|
||
| vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS | ||
| FEATURES | ||
| "glib" ENABLE_GLIB_SUPPORT # Build dbus-cxx with GLib module | ||
| "qt5" ENABLE_QT_SUPPORT # Build dbus-cxx with QT5 module | ||
| "libuv" ENABLE_UV_SUPPORT # Build dbus-cxx with libuv module | ||
| ) | ||
|
|
||
| if (EXISTS "${_VCPKG_INSTALLED_DIR}/${TARGET_TRIPLET}/lib/pkgconfig/libuv-static.pc") | ||
|
luadebug marked this conversation as resolved.
Outdated
|
||
| set(UV_STATIC ON) | ||
| else () | ||
| set(UV_STATIC OFF) | ||
| endif () | ||
|
|
||
| vcpkg_cmake_configure( | ||
| SOURCE_PATH "${SOURCE_PATH}" | ||
| OPTIONS | ||
| ${FEATURE_OPTIONS} | ||
| -DBUILD_TESTING=OFF | ||
| -DENABLE_CODE_COVERAGE_REPORT=OFF | ||
| -DENABLE_EXAMPLES=OFF | ||
| -DENABLE_TOOLS=OFF | ||
| -DBUILD_SITE=OFF | ||
| -DUV_STATIC=${UV_STATIC} | ||
| ) | ||
|
|
||
| vcpkg_cmake_install() | ||
| vcpkg_cmake_config_fixup(CONFIG_PATH "lib/cmake/dbus-cxx") | ||
| vcpkg_copy_pdbs() | ||
| vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/COPYING") | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| { | ||
| "name": "dbus-cxx", | ||
| "version": "2.6.0", | ||
| "description": "DBus-cxx provides an object-oriented interface to DBus.", | ||
| "homepage": "https://dbus-cxx.github.io/", | ||
| "license": "LGPL-3.0-or-later AND BSD-3-Clause", | ||
| "supports": "linux", | ||
| "dependencies": [ | ||
| "libsigcpp", | ||
| { | ||
| "name": "vcpkg-cmake", | ||
| "host": true | ||
| }, | ||
| { | ||
| "name": "vcpkg-cmake-config", | ||
| "host": true | ||
| } | ||
| ], | ||
| "default-features": [ | ||
| "glib", | ||
| "libuv", | ||
| "qt5" | ||
| ], | ||
|
luadebug marked this conversation as resolved.
Comment on lines
+19
to
+23
Contributor
There was a problem hiding this comment. @JavierMatosD Why is this set of default-features acceptable here and rejected in other proposal? An application wouldn't use three different dispatchers at the same time.
https://dbus-cxx.github.io/ > Features And all three options are off by default upstream.
Contributor
There was a problem hiding this comment. They are not acceptable. This was an oversight on my part and should not have been merged in its current form.
Contributor
There was a problem hiding this comment. Reverting this PR @luadebug, please reopen this PR and note we generally try to avoid using "default-features" as it was intended to only provide the minimum required for the port to be usable but default features can be difficult to disable downstream. I recommend taking a look at our docs on default features: https://learn.microsoft.com/en-us/vcpkg/concepts/default-features#role-of-default-features and its constraints https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide#default-features-should-enable-behaviors-not-apis |
||
| "features": { | ||
| "glib": { | ||
| "description": "Build dbus-cxx with GLib module", | ||
| "dependencies": [ | ||
| "glib" | ||
| ] | ||
| }, | ||
| "libuv": { | ||
| "description": "Build dbus-cxx with libuv module", | ||
| "dependencies": [ | ||
| "libuv" | ||
| ] | ||
| }, | ||
| "qt5": { | ||
| "description": "Build dbus-cxx with QT5 module", | ||
| "dependencies": [ | ||
| "qt5" | ||
| ] | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| set(VCPKG_POLICY_EMPTY_PACKAGE enabled) | ||
| vcpkg_cmake_configure( | ||
| SOURCE_PATH "${CURRENT_PORT_DIR}/project" | ||
| ) | ||
| vcpkg_cmake_build() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| cmake_minimum_required(VERSION 3.25.1) | ||
| project(dbus-cxx-test CXX) | ||
| set(CMAKE_CXX_STANDARD 17) | ||
| find_package (dbus-cxx REQUIRED CONFIG) | ||
| add_executable(main main.cpp) | ||
| target_link_libraries(main PRIVATE dbus-cxx::dbus-cxx) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| #include <dbus-cxx.h> | ||
| int main() | ||
| { | ||
| auto connection = DBus::Connection::create(DBus::BusType::SESSION); | ||
| return 0; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "name": "vcpkg-ci-dbus-cxx", | ||
| "version-string": "ci", | ||
| "description": "Validates dbus-cxx", | ||
| "dependencies": [ | ||
| "dbus-cxx", | ||
| { | ||
| "name": "vcpkg-cmake", | ||
| "host": true | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "versions": [ | ||
| { | ||
| "git-tree": "99904d636d5ea68d7a521343463323d6490a009d", | ||
| "version": "2.6.0", | ||
| "port-version": 0 | ||
| } | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.