[sleef] Use SEH on Windows while checking for CPU extensions#48143
Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom Nov 6, 2025
Merged
[sleef] Use SEH on Windows while checking for CPU extensions#48143BillyONeal merged 2 commits intomicrosoft:masterfrom
BillyONeal merged 2 commits intomicrosoft:masterfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
dg0yt
reviewed
Nov 5, 2025
Windows does not raise SIGILL, although it is emulated by MINGW runtime.
Member
|
This is entirely a product code change so we need to see this submitted upstream. Please submit this to sleef's maintainers, link to where that happened in a comment, then mark "Ready for review" |
BillyONeal
added
the
depends:upstream-changes
Contributor
Author
|
Merged upstream. Note that there has been some refactoring, so the code moved a bit. |
BillyONeal
removed
the
depends:upstream-changes
BillyONeal
approved these changes
Nov 6, 2025
Member
BillyONeal
left a comment
BillyONeal
left a comment
There was a problem hiding this comment.
I tried to use upstream's patch but it doesn't apply cleanly on this version (file is different).
Thanks for submitting upstream!
daschuer
pushed a commit
to daschuer/vcpkg
that referenced
this pull request
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MS Windows does not raise SIGILL to be caught as expected by sleef while checking for supported CPU extensions. We use standard SEH stuff on that platform. Otherwise this port is unusable on older CPUs.
./vcpkg x-add-version --alland committing the result.