[cppwinrt] Guard add_library to avoid "another target with the same name already exists" CMake error#49767
Open
nathan-white-mojang wants to merge 5 commits intomicrosoft:masterfrom
Open
[cppwinrt] Guard add_library to avoid "another target with the same name already exists" CMake error#49767nathan-white-mojang wants to merge 5 commits intomicrosoft:masterfrom
add_library to avoid "another target with the same name already exists" CMake error#49767nathan-white-mojang wants to merge 5 commits intomicrosoft:masterfrom
Conversation
dg0yt
reviewed
Feb 2, 2026
Contributor
dg0yt
left a comment
dg0yt
left a comment
There was a problem hiding this comment.
Sorry, it is not your fault, apart from theCPPWINRT_TOOL item. I just comment what I see.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Kai Pastor <dg0yt@darc.de>
dg0yt
reviewed
Apr 8, 2026
Contributor
dg0yt
left a comment
dg0yt
left a comment
There was a problem hiding this comment.
LGTM but needs nathan-white-mojang#1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49720.
Guards the
add_librarycall so that consumers of the package can callfind_packagewithout needing to guard to avoid the CMake build: