Closed
Conversation
…ting - BLOCKER: Replace path.relative() with executableTargets lookup to map test program paths to actual CMake target names. The previous approach produced file paths (e.g. 'tests/my_test') instead of target names (e.g. 'my_test'), causing cmake --build --target to fail. - BLOCKER: Fix accmulatedTestList.concat() no-op by using push(...) so tests are properly marked as errored on build failure. - MAJOR: Check return value of recursive getTestTargets() call so child failures propagate correctly to the caller. - MINOR: Add guard for empty testProgram() return to prevent nonsensical build targets from empty strings. - MINOR: Fix typo accmulatedTestList -> accumulatedTestList. - MINOR: Remove extra whitespace in for statement and redundant .toString() call. - NIT: Remove trailing semicolon after for...of block. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.