Honor environmentSetupScript output when expanding non-VS kit environmentVariables (#4091)#4869
Merged
Honor environmentSetupScript output when expanding non-VS kit environmentVariables (#4091)#4869
Conversation
hanniavalera
force-pushed
the
dev/oakeredolu/envpath
branch
from
efbd686 to
d125052
Compare
hanniavalera
force-pushed
the
dev/oakeredolu/envpath
branch
from
d125052 to
4280f26
Compare
hanniavalera
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix non-Visual Studio kit environment expansion so ${env:...} / ${env....} in environmentVariables uses the environment produced by environmentSetupScript (issue #4091).
Changes
Updated non-VS path in effectiveKitEnvironment() to expand with envOverride/penvOverride set to the post-script environment.
Preserved other caller-provided expansion options.
Added changelog entry under 1.23 Improvements with #4091.
Validation
Validated locally as seen in the screenshot, the Path variable prints both the extra paths added through the setup script and in the environmentVariables property.