Minor cleanup for resolve customizations view#308299
Merged
Conversation
Contributor
Screenshot ChangesBase: Changed (144)
|
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/SingleFeedback/Dark
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/FirstOfThree/Dark
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/ReviewOnlyTwoComments/Dark
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/MiddleOfThree/Dark
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/MixedFourComments/Dark
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/LastOfThree/Dark
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/CollapsedSingleComment/Dark
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedSingleComment/Dark
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/CollapsedMultiComment/Dark
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedMultiComment/Dark
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedFocusedFeedback/Dark
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedReviewOnly/Dark
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedMixedComments/Dark
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedFocusedReviewComment/Dark
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedReviewSuggestion/Dark
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedPRReviewOnly/Dark
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedAllSourcesMixed/Dark
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedFocusedPRReview/Dark
| Before | After |
|---|---|
 |
 |
sessions/runScriptCustomTaskWidget/WorkspaceSelectedCheckedEmpty/Dark
| Before | After |
|---|---|
 |
 |
sessions/runScriptCustomTaskWidget/WorkspaceSelectedCheckedFilled/Dark
| Before | After |
|---|---|
 |
 |
sessions/runScriptCustomTaskWidget/UserSelectedCheckedEmpty/Dark
| Before | After |
|---|---|
 |
 |
sessions/runScriptCustomTaskWidget/UserSelectedCheckedFilled/Dark
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/ZeroOfZero/Light
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/SingleFeedback/Light
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/FirstOfThree/Light
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/ReviewOnlyTwoComments/Light
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/MiddleOfThree/Light
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/MixedFourComments/Light
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorOverlayWidget/LastOfThree/Light
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/CollapsedSingleComment/Light
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedSingleComment/Light
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/CollapsedMultiComment/Light
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedMultiComment/Light
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedFocusedFeedback/Light
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedReviewOnly/Light
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedMixedComments/Light
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedFocusedReviewComment/Light
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedReviewSuggestion/Light
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedPRReviewOnly/Light
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedAllSourcesMixed/Light
| Before | After |
|---|---|
 |
 |
sessions/agentFeedback/agentFeedbackEditorWidget/ExpandedFocusedPRReview/Light
| Before | After |
|---|---|
 |
 |
sessions/runScriptCustomTaskWidget/WorkspaceSelectedCheckedEmpty/Light
| Before | After |
|---|---|
 |
 |
sessions/runScriptCustomTaskWidget/WorkspaceSelectedCheckedFilled/Light
| Before | After |
|---|---|
 |
 |
sessions/runScriptCustomTaskWidget/UserSelectedCheckedEmpty/Light
| Before | After |
|---|---|
 |
 |
sessions/runScriptCustomTaskWidget/UserSelectedCheckedFilled/Light
| Before | After |
|---|---|
 |
 |
sessions/runScriptCustomTaskWidget/WorkspaceUnavailableCheckedEmpty/Dark
| Before | After |
|---|---|
 |
 |
sessions/runScriptCustomTaskWidget/WorkspaceUnavailableCheckedFilled/Dark
| Before | After |
|---|---|
 |
 |
sessions/runScriptCustomTaskWidget/ExistingUserTaskLockedChecked/Dark
| Before | After |
|---|---|
 |
 |
sessions/aiCustomizationShortcutsWidget/Expanded/Dark
| Before | After |
|---|---|
 |
 |
sessions/aiCustomizationShortcutsWidget/WithMcpServers/Dark
| Before | After |
|---|---|
 |
 |
sessions/aiCustomizationShortcutsWidget/WithCounts/Dark
| Before | After |
|---|---|
 |
 |
chat/aiStats/AiStatsHover/Dark
| Before | After |
|---|---|
 |
 |
chat/aiStats/AiStatsHoverNoData/Dark
| Before | After |
|---|---|
 |
 |
chat/chatProgressContentPart/WithCustomIcon/Dark
| Before | After |
|---|---|
 |
 |
chat/chatQuestionCarousel/SingleTextQuestion/Dark
| Before | After |
|---|---|
 |
 |
chat/chatQuestionCarousel/SingleSelectQuestion/Dark
| Before | After |
|---|---|
 |
 |
chat/chatQuestionCarousel/MultiSelectQuestion/Dark
| Before | After |
|---|---|
 |
 |
sessions/runScriptCustomTaskWidget/WorkspaceUnavailableCheckedEmpty/Light
| Before | After |
|---|---|
 |
 |
sessions/runScriptCustomTaskWidget/WorkspaceUnavailableCheckedFilled/Light
| Before | After |
|---|---|
 |
 |
sessions/runScriptCustomTaskWidget/ExistingUserTaskLockedChecked/Light
| Before | After |
|---|---|
 |
 |
sessions/aiCustomizationShortcutsWidget/Expanded/Light
| Before | After |
|---|---|
 |
 |
sessions/aiCustomizationShortcutsWidget/WithMcpServers/Light
| Before | After |
|---|---|
 |
 |
sessions/aiCustomizationShortcutsWidget/WithCounts/Light
| Before | After |
|---|---|
 |
 |
chat/aiStats/AiStatsHover/Light
| Before | After |
|---|---|
 |
 |
chat/aiStats/AiStatsHoverNoData/Light
| Before | After |
|---|---|
 |
 |
chat/chatProgressContentPart/WithCustomIcon/Light
| Before | After |
|---|---|
 |
 |
chat/chatQuestionCarousel/SingleTextQuestion/Light
| Before | After |
|---|---|
 |
 |
chat/chatQuestionCarousel/SingleSelectQuestion/Light
| Before | After |
|---|---|
 |
 |
chat/chatQuestionCarousel/MultiSelectQuestion/Light
| Before | After |
|---|---|
 |
 |
chat/chatQuestionCarousel/MultipleQuestions/Dark
| Before | After |
|---|---|
 |
 |
chat/chatQuestionCarousel/NoSkip/Dark
| Before | After |
|---|---|
|
 |
chat/promptFilePickers/PromptFiles/Dark
| Before | After |
|---|---|
 |
 |
chat/promptFilePickers/InstructionFilesWithAgentInstructions/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationListWidget/InstructionsTabWithItems/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationListWidget/InstructionsTabEmpty/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/LocalHarness/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/CliHarness/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/ClaudeHarness/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/Sessions/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/SessionsSkillsTab/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTab/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTab/Dark
| Before | After |
|---|---|
|
|
chat/aiCustomizations/aiCustomizationManagementEditor/SkillsTab/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/InstructionsTab/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/HooksTab/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTab/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTab/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/PluginBrowseMode/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTabScrolled/Dark
| Before | After |
|---|---|
|
 |
chat/chatQuestionCarousel/MultipleQuestions/Light
| Before | After |
|---|---|
 |
 |
chat/chatQuestionCarousel/NoSkip/Light
| Before | After |
|---|---|
|
 |
chat/promptFilePickers/PromptFiles/Light
| Before | After |
|---|---|
 |
 |
chat/promptFilePickers/InstructionFilesWithAgentInstructions/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationListWidget/InstructionsTabWithItems/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationListWidget/InstructionsTabEmpty/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/LocalHarness/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/CliHarness/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/ClaudeHarness/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/Sessions/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/SessionsSkillsTab/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTab/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTab/Light
| Before | After |
|---|---|
|
|
chat/aiCustomizations/aiCustomizationManagementEditor/SkillsTab/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/InstructionsTab/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/HooksTab/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTab/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTab/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/PluginBrowseMode/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTabScrolled/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabScrolled/Light
| Before | After |
|---|---|
|
 |
chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabScrolled/Light
| Before | After |
|---|---|
|
|
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabNarrow/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTabNarrow/Light
| Before | After |
|---|---|
 |
 |
baseUI/Buttons/Light
| Before | After |
|---|---|
 |
 |
baseUI/ButtonBar/Light
| Before | After |
|---|---|
 |
 |
baseUI/Toggles/Light
| Before | After |
|---|---|
 |
 |
editor/codeActionList/SimpleQuickFixes/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/SideBySideView/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/WordReplacementView/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletionsExtras/HintsToolbar/Light
| Before | After |
|---|---|
 |
 |
editor/inlineCompletionsExtras/HintsToolbarHovered/Light
| Before | After |
|---|---|
|
|
editor/inlineCompletionsExtras/JumpToHint/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabScrolled/Dark
| Before | After |
|---|---|
|
 |
chat/aiCustomizations/aiCustomizationManagementEditor/PluginsTabScrolled/Dark
| Before | After |
|---|---|
|
|
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersTabNarrow/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/AgentsTabNarrow/Dark
| Before | After |
|---|---|
 |
 |
baseUI/Buttons/Dark
| Before | After |
|---|---|
 |
 |
baseUI/ButtonBar/Dark
| Before | After |
|---|---|
 |
 |
baseUI/Toggles/Dark
| Before | After |
|---|---|
 |
 |
editor/codeActionList/SimpleQuickFixes/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/SideBySideView/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/WordReplacementView/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletionsExtras/HintsToolbar/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletionsExtras/HintsToolbarHovered/Dark
| Before | After |
|---|---|
|
|
editor/inlineCompletionsExtras/JumpToHint/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletionsExtras/GutterMenu/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletionsExtras/GutterMenu/Light
| Before | After |
|---|---|
 |
 |
editor/suggestWidget/MethodCompletions/Light
| Before | After |
|---|---|
 |
 |
editor/suggestWidget/MixedKinds/Light
| Before | After |
|---|---|
 |
 |
editor/suggestWidget/MethodCompletions/Dark
| Before | After |
|---|---|
 |
 |
editor/suggestWidget/MixedKinds/Dark
| Before | After |
|---|---|
 |
 |
Added (2)
editor/multiDiffEditor/MultiDiffEditor/Light
editor/multiDiffEditor/MultiDiffEditor/Dark
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the Chat Debug “Resolve Customizations” experience by enriching customization resolution logs (notably hooks) and making the detail panel/file navigation less disruptive during layout and file opening.
Changes:
- Switch customization hook logging to parse hook files into per-command entries with source URIs, and localize customization summary count labels.
- Preserve scroll position in the debug detail panel across layout changes.
- Open file links from debug lists with
preserveFocusand group hook entries by lifecycle event in the summary UI.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/promptsDebugContribution.ts | Changes how customization events collect/log hook information and localizes summary fragments. |
| src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugDetailPanel.ts | Preserves scroll position when the panel is re-laid out. |
| src/vs/workbench/contrib/chat/browser/chatDebug/chatCustomizationDiscoveryRenderer.ts | Opens debug file links without stealing focus; groups hook entries in the summary view. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 3
src/vs/workbench/contrib/chat/browser/promptsDebugContribution.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/promptsDebugContribution.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/chat/browser/promptsDebugContribution.ts
Outdated
Show resolved
Hide resolved
justschen
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.