Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves integrated browser tool behavior by returning richer “already open” results and by formatting tracked browser page context consistently, helping discourage agents from opening redundant browser tabs (fixes #306971).
Changes:
- Replace single-page “already open” responses with a multi-page summary result (
getExistingPagesResult) and shared formatting (formatBrowserEditorList). - Update the browser pages chat context publisher to use the shared formatter.
- Improve Playwright tab snapshot/reporting and request-finish waiting behavior.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/browserView/electron-browser/tools/openBrowserToolNonAgentic.ts | Reuses new existing-pages result helper for non-agentic open behavior. |
| src/vs/workbench/contrib/browserView/electron-browser/tools/openBrowserTool.ts | Reuses new existing-pages result helper for agentic open behavior. |
| src/vs/workbench/contrib/browserView/electron-browser/tools/browserTools.contribution.ts | Uses shared formatter to publish tracked browser pages into chat context. |
| src/vs/workbench/contrib/browserView/electron-browser/tools/browserToolHelpers.ts | Introduces shared formatting + multi-page existing-pages detection/result building. |
| src/vs/platform/browserView/node/playwrightTab.ts | Fixes snapshot availability check and uses cancelable timeout race for request completion waits. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 3
src/vs/workbench/contrib/browserView/electron-browser/tools/browserToolHelpers.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/browserView/electron-browser/tools/browserToolHelpers.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/browserView/electron-browser/tools/browserToolHelpers.ts
Show resolved
Hide resolved
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @jrualesMatched files:
|
dmitrivMS
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #306971