Skip to content

sessions: changes modal UX polish - remove twistie padding and add header#308338

Merged
osortega merged 2 commits intomainfrom
copilot/zealous-aardvark
Apr 7, 2026
Merged

sessions: changes modal UX polish - remove twistie padding and add header#308338
osortega merged 2 commits intomainfrom
copilot/zealous-aardvark

Conversation

@osortega
Copy link
Copy Markdown
Contributor

@osortega osortega commented Apr 7, 2026

Summary

Fixes #307705

Two UX polish fixes for the Changes modal sidebar in the agents window:

1. Remove left-padding from force-no-twistie in list mode

The twistie element was taking up 10px of width even when hidden, causing misaligned padding compared to the main changes list. Now set to width: 0scoped to .agent-sessions-workbench only.

2. Add a "Changes" header with count badge

Adds a header row above the file list in the modal sidebar, displaying "Changes" with a CountBadge showing the file count. This improves organization and consistency with the right-panel changes list.

Files changed

  • src/vs/sessions/browser/media/style.css — sessions-scoped twistie override
  • src/vs/sessions/contrib/changes/browser/changesView.ts — add header + CountBadge to renderSidebarList()
  • src/vs/sessions/contrib/changes/browser/media/changesView.css — header styling

…ader

- Remove left-padding from force-no-twistie in the modal sidebar
  (scoped to agent-sessions-workbench only)
- Add a 'Changes' header with CountBadge to the modal sidebar list

Fixes #307705

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 7, 2026 21:43
@osortega
Copy link
Copy Markdown
Contributor Author

osortega commented Apr 7, 2026

Before

Screenshot 2026-04-07 at 2 36 46 PM

After

Screenshot 2026-04-07 at 2 36 51 PM

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Polishes the Changes modal sidebar UX in the Agents (sessions) window by aligning list padding with the main changes list and adding a small header section for clarity.

Changes:

  • Override the modal sidebar “force-no-twistie” twistie width to remove the leftover indentation in list mode (scoped to .agent-sessions-workbench).
  • Add a “Changes” header row with a CountBadge showing the number of files in the modal sidebar list.
  • Add CSS styling for the new modal sidebar header.
Show a summary per file
File Description
src/vs/sessions/browser/media/style.css Sessions-scoped CSS override to eliminate twistie width/padding in the modal sidebar.
src/vs/sessions/contrib/changes/browser/changesView.ts Adds the modal sidebar header + count badge and adjusts tree layout to account for header height.
src/vs/sessions/contrib/changes/browser/media/changesView.css Styles the new “Changes” header row in the modal sidebar list container.

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 1

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@osortega osortega marked this pull request as ready for review April 7, 2026 22:32
@osortega osortega enabled auto-merge (squash) April 7, 2026 22:32
@osortega osortega merged commit 7e640cf into main Apr 7, 2026
23 checks passed
@osortega osortega deleted the copilot/zealous-aardvark branch April 7, 2026 22:35
@vs-code-engineering vs-code-engineering bot added this to the 1.116.0 milestone Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changes modal polish/UX updates requests

3 participants