Add case-insensitive label name resolution for jump targets#183
Merged
Conversation
4 tasks
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughAdds a new ChangesMenu Choice Jump-Target Label Resolution
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coderabbitai
Bot
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
apps/backend/src/services/labels.service.ts (3)
2515-2515: 💤 Low valueSimplify condition: redundant truthiness check.
Since
choice.targetLabelIdis typed asstring(non-nullable), checkingchoice.targetLabelId &&is redundant. The condition can be simplified to just check for empty string:- if (choice.targetLabelId && choice.targetLabelId !== "") { + if (choice.targetLabelId !== "") {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/backend/src/services/labels.service.ts` at line 2515, The condition using `choice.targetLabelId && choice.targetLabelId !== ""` is redundant because `choice.targetLabelId` is a non-nullable string; update the conditional (e.g., inside the function handling choices where `choice.targetLabelId` is checked) to a single check like `if (choice.targetLabelId !== "")` (or `if (choice.targetLabelId.length > 0)`) referencing `choice.targetLabelId` to simplify the logic.
1670-1679: ⚖️ Poor tradeoffPerformance: Fetching all project labels may be inefficient for large projects.
The query fetches all non-deleted labels in the project to resolve jump targets. For projects with thousands of labels, this could impact response time in
getLabel. Consider whether resolution could be optimized by:
- Only fetching labels that match the target names found in menuOptions
- Caching the label name→ID mapping at the project level
However, if typical projects have a reasonable number of labels and this read-time resolution is intentional per the PR design, this may be acceptable.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/backend/src/services/labels.service.ts` around lines 1670 - 1679, The current implementation loads all non-deleted labels for a project into allLabels and calls resolveJumpTargets(lines, allLabels), which is inefficient for large projects; change it to first extract the set of jump target names from lines/menuOptions (the parsed targets used by resolveJumpTargets) and then query only matching labelName values (and projectId/isNull(deletedAt)) instead of selecting every label, or alternatively wire in a project-level label name→ID cache used by getLabel and resolveJumpTargets to avoid full scans; update the code paths that build allLabels and the callsite of resolveJumpTargets accordingly so they use the filtered query result or cached mapping.
2504-2504: Fix concern:resolveLabelNamessafely handleslabelName: null
- In
apps/backend/src/services/label-name-resolver.service.ts,resolveLabelNamesguards withif (label.labelName)before callingtoLowerCase(), sonulllabel names are skipped without throwing.- Existing unit tests (
apps/backend/src/services/__tests__/label-name-resolver.service.unit.test.ts) cover nonexistent labels and empty lists, but don’t include a case where an input label haslabelName: null; adding that test would prevent regressions.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/backend/src/services/labels.service.ts` at line 2504, The resolver must safely handle labels with labelName: null and we need a unit test to prevent regressions: ensure resolveLabelNames (in label-name-resolver.service.ts) checks label.labelName truthiness before calling toLowerCase() (preserve or add the if (label.labelName) guard) and skip/null-map those entries, and add a new test case in label-name-resolver.service.unit.test.ts that passes an input label with labelName: null (and asserts the function returns without throwing and treats that entry as unresolved/unchanged per existing behavior); reference the resolveLabelNames function when making the check and the unit test file when adding the new case.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/frontend/src/hooks/useTechnicalInfo.ts`:
- Around line 105-117: The inline choice typing in useTechnicalInfo.ts (the
info.choices = line.menuOptions.map(...) block) diverges from the shared
LabelLine["menuOptions"] contract by introducing effects; either add effects
(and nested stats) to the shared type in packages/shared/src/index.ts so the
component can safely reference choice.effects, or remove/stop using effects here
and derive the choice type from LabelLine["menuOptions"][number] (instead of an
inline type) so the mapping aligns with the shared contract; update the
info.choices mapping and any callers to use the unified shared type (referencing
LabelLine and the info.choices assignment) accordingly.
---
Nitpick comments:
In `@apps/backend/src/services/labels.service.ts`:
- Line 2515: The condition using `choice.targetLabelId && choice.targetLabelId
!== ""` is redundant because `choice.targetLabelId` is a non-nullable string;
update the conditional (e.g., inside the function handling choices where
`choice.targetLabelId` is checked) to a single check like `if
(choice.targetLabelId !== "")` (or `if (choice.targetLabelId.length > 0)`)
referencing `choice.targetLabelId` to simplify the logic.
- Around line 1670-1679: The current implementation loads all non-deleted labels
for a project into allLabels and calls resolveJumpTargets(lines, allLabels),
which is inefficient for large projects; change it to first extract the set of
jump target names from lines/menuOptions (the parsed targets used by
resolveJumpTargets) and then query only matching labelName values (and
projectId/isNull(deletedAt)) instead of selecting every label, or alternatively
wire in a project-level label name→ID cache used by getLabel and
resolveJumpTargets to avoid full scans; update the code paths that build
allLabels and the callsite of resolveJumpTargets accordingly so they use the
filtered query result or cached mapping.
- Line 2504: The resolver must safely handle labels with labelName: null and we
need a unit test to prevent regressions: ensure resolveLabelNames (in
label-name-resolver.service.ts) checks label.labelName truthiness before calling
toLowerCase() (preserve or add the if (label.labelName) guard) and skip/null-map
those entries, and add a new test case in
label-name-resolver.service.unit.test.ts that passes an input label with
labelName: null (and asserts the function returns without throwing and treats
that entry as unresolved/unchanged per existing behavior); reference the
resolveLabelNames function when making the check and the unit test file when
adding the new case.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 85a980e6-b878-4d91-b1f2-d333129fe142
📒 Files selected for processing (10)
apps/backend/scripts/seed-technical-badges.tsapps/backend/src/db/schema/tables/label-lines.tsapps/backend/src/services/__tests__/label-name-resolver.service.unit.test.tsapps/backend/src/services/__tests__/resolve-jump-targets.service.unit.test.tsapps/backend/src/services/label-name-resolver.service.tsapps/backend/src/services/labels.service.tsapps/backend/src/services/rpy-parser.service.tsapps/frontend/src/hooks/useTechnicalInfo.tsapps/frontend/src/pages/auth/__tests__/login.test.tsxpackages/shared/src/index.ts
…ptions and label lines; resolve jump targets to label IDs
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Tests
Data / Seed