feat: mobile responsive infrastructure foundation (#262)#265
Merged
Conversation
- Add mobile (375px) breakpoint to Tailwind config - Bump all button size variants to 44px minimum (WCAG 2.5.5 touch target) - Ensure Switch, Select trigger, and Tabs trigger meet 44px minimum height - Add 44x44px touch target to DialogShell close button - Add mobile-responsive padding (max-mobile:p-4) to DialogContent, DialogShell, and ConfirmDialog - Restructure Switch component with proper touch target wrapper
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds a 375px mobile breakpoint and updates shared base UI components to increase touch targets and apply responsive padding in dialog layouts. ChangesMobile responsive infrastructure
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/frontend/tailwind.config.js`:
- Around line 25-27: The Tailwind breakpoint config in the main theme is
overriding all default responsive variants, leaving only the custom `mobile`
screen. Move the `mobile` entry from `theme.screens` into `theme.extend.screens`
in the Tailwind config so the default `sm`/`md`/`lg`/`xl`/`2xl` breakpoints
remain available across the frontend.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ec3fbbf1-0ec0-4ef9-b896-9dfbb5ec3c2f
📒 Files selected for processing (8)
apps/frontend/src/components/ui/DialogShell.tsxapps/frontend/src/components/ui/button-variants.tsapps/frontend/src/components/ui/confirm-dialog.tsxapps/frontend/src/components/ui/dialog.tsxapps/frontend/src/components/ui/select.tsxapps/frontend/src/components/ui/switch.tsxapps/frontend/src/components/ui/tabs.tsxapps/frontend/tailwind.config.js
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/frontend/src/components/ui/input.tsx`:
- Around line 31-34: The non-file input styling in input and inputVariants
applies min-h-11 universally, which makes size="sm" lose its compact height.
Update the class logic in the input component so the 44px minimum only applies
when size is "default" (or otherwise constrain it to the intended touch-target
case), while preserving the smaller height for the sm variant.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3964c7b9-210f-48cb-ac78-f30627f40288
📒 Files selected for processing (2)
apps/frontend/src/components/ui/input.tsxapps/frontend/tailwind.config.js
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/frontend/tailwind.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #262
What changed
CSS & Tokens
mobile: 375pxbreakpoint to Tailwindscreensconfig, enablingmobile:andmax-mobile:variantsTouch targets (WCAG 2.5.5)
default,sm,lg,icon) bumped to 44px minimum height viah-11/min-h-11+min-w-11on iconmin-h-11for 44px minimum heightmin-h-11for 44px minimum heightsize-11with flex centering and rounded corners (44x44px touch target)Dialogs
max-mobile:p-4to reduce padding on screens <375pxmax-mobile:p-4on header, body, and footer sectionsmax-mobile:p-4on header and footer sectionsTable
overflow-autowrapper already handles horizontal overflow correctly — no changes neededVerification
pnpm typecheck— passes across all 4 projectspnpm lint(frontend) — 2 pre-existing warnings onlypnpm test(frontend) — 860/861 pass (1 pre-existing flaky performance benchmark timeout)Files changed
apps/frontend/tailwind.config.jsapps/frontend/src/components/ui/button-variants.tsapps/frontend/src/components/ui/switch.tsxapps/frontend/src/components/ui/select.tsxapps/frontend/src/components/ui/tabs.tsxapps/frontend/src/components/ui/DialogShell.tsxapps/frontend/src/components/ui/dialog.tsxapps/frontend/src/components/ui/confirm-dialog.tsx@oracle review
Skipped — diff is small (~50 lines, 8 files), doesn't touch auth/DB/API routes/security boundaries, and architectural choices are straightforward (Tailwind class changes + one component restructure).
Summary by CodeRabbit
New Features
mobile(375px) breakpoint to improve responsive behavior on smaller screens.Bug Fixes