feat(tags): tags page with create/rename/delete and usage counts#114
Open
mikkisguy wants to merge 5 commits into
Open
feat(tags): tags page with create/rename/delete and usage counts#114mikkisguy wants to merge 5 commits into
mikkisguy wants to merge 5 commits into
Conversation
Replace the /tags placeholder with a full tag-management page: lists every tag with its usage count, toggles sort by name or count, and drives create / rename / delete through the existing /api/tags endpoints. Client-side validation mirrors the server contract and a 409 maps to an inline "already exists" message; dialogs block every dismiss path while a mutation is in flight so destructive deletes can't be silently cancelled. Bumps version to 0.14.0. Co-authored-by: Cursor <cursoragent@cursor.com>
Swap the blue primary fill on the tags page's prominent actions (New tag, Create, Save) for a high-contrast cream-on-dark "inverted" variant, keeping blue reserved for brand/links. Delete stays destructive.
Switch all buttons to JetBrains Mono and add a 200ms border-color fade on hover (transparent → cream hairline), with per-variant overrides so the hairline stays visible on the cream inverted and red destructive fills and is suppressed on the borderless link. Applies the same treatment to the bespoke login submit button. Bumps version to 0.15.0.
mikkisguy
force-pushed
the
issue/27-tags-page
branch
from
f8d035a to
f6f18b0
Compare
Reserve JetBrains Mono for inverted primary buttons and dialog chrome (title + footer actions) so mono reads as a deliberate accent while secondary controls stay in the UI sans. Replace Inter with Geist for a better technical/editorial pairing with Newsreader and JetBrains Mono.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27.
What changed
Replaces the
/tagsplaceholder with a full tag-management page (Phase 3 — Web UI Core):GET /api/tags./api/tagsand/api/tags/[id]endpoints and refresh the list (and its counts) on success.[a-zA-Z0-9 _-], case-insensitive uniqueness); a 409 from a concurrent create maps to an inline "already exists" message.No API routes, DB, or auth code were touched — this is UI over the existing endpoints.
Files
src/app/tags/{page,tags-page,tag-form-dialog,delete-tag-dialog}.tsx,{api,use-tags,types}.tsapi.test.ts,use-tags.test.tsx,tags-page.test.tsx0.14.0(package.json + README badge)Review pass
A strategic/large-diff review (>200 lines) flagged one material issue — dialogs could be dismissed mid-mutation, letting a destructive delete complete after an apparent cancel. Fixed: all dismiss paths (Escape, overlay, X, Cancel) are now blocked while a create/rename/delete is in flight, with a regression test. No remaining must-fix/should-fix findings.
Verification
pnpm verifyis green locally: lint, typecheck, build, 816 tests (26 new for the tags page), knip.Made with Cursor